Repository navigation
chore(core): the layer runtime's exit copy, for a touch presentation's close #8186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
1fda019
chore(core): the layer runtime's exit copy, for a touch presentation'…
vjeux 515dd46
Merge branch 'main' into uikit/c26-layer-exit-copy
cixzhang 1cc771f
Merge branch 'main' into uikit/c26-layer-exit-copy
vjeux 544ddee
fix(core): the exit copy keeps no closed layer
vjeux 0e69c33
docs(core): the exit copy's JSDoc states the empty-canvas rule once
vjeux 223875a
Merge main into the layer exit copy branch (layer-runtime.md verifica…
cixzhang 6ecb859
Merge main into the layer exit copy branch (#8147 landed)
cixzhang d7905ea
Merge main into the layer exit copy branch (placeOver's beforeNode be…
cixzhang c2dc518
Merge main into the layer exit copy branch (#10224 landed)
cixzhang 30e42ae
fix(core): the exit copy reads its host's style before the insertion
vjeux File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@astryxdesign/core': patch | ||
| --- | ||
|
|
||
| [chore] Internal: the layer runtime gains one exit copy for touch presentations that animate a popover out: a static, inert copy of the closing popover, shown only in the top layer where the popover was drawn, for the close to play on. Core's other inert copies now join no form, carry no anchor name and keep their color scheme, as their documentation says. | ||
|
|
||
| @vjeux |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As implemented, only the
nameandformattributes are removed, so a copy placed beside a layer inside a<form>is owned by that form. Either keep this guarantee in code (layerExitCopy.ts:206-209) or narrow it here, in the Exit copy section and in the INV13 verification row to "no form names and noformattribute".