Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
AI review status for this pull request.
|
There was a problem hiding this comment.
Approval is on hold for an engineering owner's spec decision: the branch adds architecture:layer-runtime INV13 and its Exit copy section, rewrites the gesture-tuning ruling in spec:AST-057, and ships a press-feedback exception to spec:AST-094 FR19 that its own README calls pending. An engineering owner can record approval of the head's records by commenting /approve-spec <full head SHA> on this pull request (the author may do this as an engineering owner), while the FR19 exception needs its amendment on main or should come out. Separately, please land the stacked dependencies and rebase so this pull request carries only the lift commit, since the branch now has 39,463 authored changed lines.
.changeset/touch-selection-lock.mdannounces a[fix]for sliders, switches and segmented controls that no component is wired to here.liftScaleinpackages/core/src/lift/liftGeometry.tsbounds only the width, so a trigger taller than the viewport lifts past the bottom gutter andsurfacePlacementputs its menu above the top.
[Automated review]
There was a problem hiding this comment.
Approval is on hold for an engineering owner's spec decision: the branch adds architecture:layer-runtime INV13 and its Exit copy section, rewrites the gesture-tuning ruling in spec:AST-057, and ships a press-feedback exception to spec:AST-094 FR19 that its own README calls pending. An engineering owner can approve the head's records by commenting /approve-spec <full head SHA> on this pull request (the author may do so as an engineering owner), while the FR19 exception needs its amendment on main or should come out. Separately, please land the stacked dependencies and rebase so this pull request carries only the lift (31,587 authored changed lines today), and fix these:
createLayerinpackages/core/src/lift/lift.tsgives the viewport-covering lift layertouch-action: none, so a pinch cannot zoom the page while a trigger is lifted (spec:AST-094FR10, FR35);touch-action: pinch-zoomstill keeps one-finger pans off.liftScaleinpackages/core/src/lift/liftGeometry.tsbounds only the width, so a trigger taller than the viewport less its gutters lifts past the bottom gutter, andsurfacePlacementthen answersabovewith no room there.- The
spec:AST-057edit calls the row's motion roles theme motion roles and drops durations from its Not public list, whichspec:AST-094FR4 and DEC-11 do not allow yet.
[Automated review]
|
Posted by Cindy's agent on her behalf. A naming change to match the records: please rename the module and its exports from lift to liftFromTrigger, for example |
|
On it. This pull request's next push renames the module and its exports to match
ContextMenu's imports follow in #8201. That push also folds the new foundation heads. |
|
Renamed in 6004a1e: |
…functions A float64 hash of easedProgress's values is not the same on every platform: macOS arm64 and CI's Linux give different hashes for main's code. The test now keeps copies of easedProgress and solveAnimatedPageScroll as they are on main (ebb9dde), and checks that the shipped functions give the same number, bit for bit (Object.is), for each position and velocity on the grid. From rest, the pager's velocity at t <= 0 stays the one value left out. Based on vjeux's test (vjeux/astryx coverage/rect-morph-first-instant)
liftCopy had no caller. It goes with its hide count per source, its picture read, its corner read and their tests, fixture and README part. It returns with the viewer that uses it.
No caller closed a surface through the lift: a menu closes with its own exit. dismissSurface goes with its exit copy and the fields only it read. The drop now waits for the source alone, and the fixture, the browser proofs, the README and the changeset no longer describe the close.
liftFromTriggerGeometry.ts served only the lift and one placement read. Its three functions and their types move into liftFromTrigger.ts, and their unit tests into liftFromTrigger.test.ts, unchanged.
useLiftFromTrigger wrapped createLiftFromTrigger for its one caller. That caller creates the lift and ends it at unmount itself.
No caller grew a surface out of a press: ContextMenu fades its menu in where it rests. presentSurface loses its press, the lift loses surfaceStartWidth, and the proof of the growth from a press goes.
INV15 names createLiftFromTrigger and surfacePlacement, the module's two entry points. With the surface close gone from the module, a surface beside the lift keeps its own exit.
There was a problem hiding this comment.
Needs an engineering owner's decision, plus one fix. This pull request was reviewed on its own, because its Stack line names two tops (#8485 and #8080) and #8508 does not carry it.
Approval waits on an engineering owner deciding this branch's edit to architecture:layer-runtime INV15, which removes "the exit, played through the runtime's exit copy (INV14)" from the lift module, says a surface beside the lift keeps its own exit, and names createLiftFromTrigger and surfacePlacement as the entry points. An engineering owner records that decision by commenting /approve-spec <full head SHA> on this pull request (the author may, as an engineering owner); otherwise restore the exit-copy path or drop the INV15 edit.
Blocking:
- Regression: since #9724 landed on
main,packages/core/src/SegmentedControl/useSegmentedSelectionMotion.ts:44-45conflicts withmain, so GitHub cannot merge this pull request and CI cannot run; mergemainand keep both imports.
The lift marks its layer, its anchor box and its placeholder. The exit copy's mark went with the exit copy. Comment only.
…ect-morph # Conflicts: # packages/core/src/SegmentedControl/useSegmentedSelectionMotion.ts
There was a problem hiding this comment.
Needs an engineering owner's decision, plus one fix. This pull request was reviewed on its own, because #9764, #9769, #8485 and #8201 carry different Stack lines.
Approval waits on an engineering owner deciding this branch's edit to architecture:layer-runtime INV15, which removes "the exit, played through the runtime's exit copy (INV14)" from the lift module, says a surface beside the lift keeps its own exit, and names createLiftFromTrigger and surfacePlacement as its entry points. An engineering owner records that decision by commenting /approve-spec <full head SHA> on this pull request (the author may, as an engineering owner); otherwise restore the exit-copy path or drop the INV15 edit.
Blocking:
- Miss: a second
drop()while the trigger is still returning settles the first dismissal and ends the lift at once (packages/core/src/liftFromTrigger/liftFromTrigger.ts:1020), so the trigger snaps to its place and the tint vanishes instead of the return continuing asspec:AST-094FR6 requires; make a repeateddrop()a no-op while one is in flight and add a unit case for it.
A second drop while the source returns must change nothing: the source keeps returning on its spring, and the tint keeps clearing.
A drop while the source returned retargeted the return and settled the first one at once: the source snapped to its place and the tint vanished. The first drop now marks the lift as dropping, and a later drop changes nothing until the lift ends.
There was a problem hiding this comment.
Needs an engineering owner's decision and one fix, and approval waits for CI. This pull request was reviewed on its own, since #9764, #9769, #8485 and #8201 carry different Stack lines; the repeated drop() snap from the last review is fixed.
Approval waits on an engineering owner deciding this branch's architecture:layer-runtime INV15 edit, which removes "the exit, played through the runtime's exit copy (INV14)" from the lift module, says a surface beside the lift keeps its own exit, and names createLiftFromTrigger and surfacePlacement as its entry points: an engineering owner records it by commenting /approve-spec <full head SHA> on this pull request (the author may, as an engineering owner), or else the exit-copy path comes back or the INV15 edit leaves the branch. CI has not run on this head because it is a draft from a fork: once it is ready for review, a maintainer adds the ci:run label so CI runs.
Blocking:
- Newly live check: the description's Testing section still lists a
liftCopyzoom proof ("In the lift fixture", step 3, and "The unit tests ... cover the same") that this head removed withliftCopy, so drop that step, point step 2's turn-around at the rect morph's own proof, and label the "At this head" checks that name an older commit as earlier.
Claims and files checked
- Changeset
lift-module.md: verified (three elements while lifted, translate, scale and opacity only, no shadow, not exported, no component uses it). - Changeset
motion-morph-path.md: verified (lerpPath,edgeGrowPath,morphCurves; not exported). - Changeset
motion-rect-morph.md: verified (createRectMorphon a copy or itself;easedProgresskeeps its values;timedCurvefor the pager and the morph). - Description, Change and API sections (
createLiftFromTrigger,surfacePlacementandnone, rect morph and::backdroptint, velocity on a drop, no shadow,touch-action: pinch-zoom, both gutters, caller-named marks,onLayerShown,pin, nothing imports the module, line counts): verified. - Description, Testing commit list and local-check counts (26 unit cases; 13 browser tests, 2 skipped in WebKit): match the code; not rerun here.
- Description, "In the lift fixture" step 3 and "cover the same": false (no
liftCopyor zoom proof at this head); step 2's turn-around: not proven in the lift fixture; checks labelled "At this head" that name an older commit: stale. - Description, performance numbers and app-level size: from an earlier head, not checkable here.
- Files with a finding:
docs/architecture/layer-runtime.md(INV15 edit on hold; gaps paragraph status, non-blocking),packages/core/src/liftFromTrigger/liftFromTrigger.ts(onLayerShowndoc, non-blocking). - Files clear:
.changeset/lift-module.md,.changeset/motion-morph-path.md,.changeset/motion-rect-morph.md,docs/architecture/react-component-runtime.md,docs/specs/AST-094-touch-presentations/spec.md,packages/core/src/Popover/popoverSurfaceMotion.ts,packages/core/src/SegmentedControl/useSegmentedSelectionMotion.ts,packages/core/src/liftFromTrigger/README.md,packages/core/src/liftFromTrigger/__tests__/liftFromTrigger.fixture.ts,packages/core/src/liftFromTrigger/__tests__/liftFromTrigger.interaction.browser.spec.ts,packages/core/src/liftFromTrigger/liftFromTrigger.test.ts,packages/core/src/motion/README.md,packages/core/src/motion/__tests__/callerMotionValues.test.ts,packages/core/src/motion/__tests__/motionBundle.ts,packages/core/src/motion/__tests__/rectMorph.interaction.browser.spec.ts,packages/core/src/motion/morphPath.test.ts,packages/core/src/motion/morphPath.ts,packages/core/src/motion/paging.test.ts,packages/core/src/motion/paging.ts,packages/core/src/motion/progress.test.ts,packages/core/src/motion/progress.ts,packages/core/src/motion/rectMorph.test.ts,packages/core/src/motion/rectMorph.ts,packages/core/src/motion/themeTiming.server.test.ts,packages/core/src/motion/themeTiming.test.ts,packages/core/src/motion/themeTiming.ts,scripts/snap-paging-bundle.test.mjs.
The layer runtime's gaps paragraph states INV15's gap as what a reader can see: ContextMenu and Lightbox do not use the module. The onLayerShown doc says it runs before the source's writes, and what the page holds then. Records and comments only.
There was a problem hiding this comment.
Needs an engineering owner's decision on one record edit; no blocking defect remains. Approval waits on an engineering owner deciding this branch's architecture:layer-runtime INV15 edit, which removes “the exit, played through the runtime's exit copy (INV14)” from the lift module, says a surface beside the lift keeps its own exit, and names createLiftFromTrigger and surfacePlacement as its entry points: an engineering owner records it by commenting /approve-spec <full head SHA> on this pull request (the author may, as an engineering owner), or else the exit-copy path comes back or the INV15 edit leaves the branch. CI has not run on this head because it is a draft from a fork; once it is ready for review, a maintainer adds the ci:run label so CI runs. This pull request was reviewed on its own, since #9764, #9769, #8485 and #8201 carry different Stack lines.
Non-blocking:
- Miss: the lift's README says its “document listeners” end with it, but the module listens on its own layer and the window's input stream, so “listeners” keeps it true.
- Still open from the last review:
onLayerShown's doc could say thatpresentSurface(),drop()anddispose()do nothing inside it, because the lift records its state after the callback. - Miss: two history items in the description (the zoom copy's marks, the menu growth proof) describe code this head no longer has, and the title's scope
liftcould readliftFromTriggerto match the module.
Claims and files checked
- Changeset for the lift module: verified (the trigger lifts above a tint, a surface fades in on the rect morph, translate, scale and opacity only, three elements while lifted, no shadow, not exported, no component uses it).
- Changeset for the morph paths: verified (straight and edge-growth paths, an interrupted motion continuing in each path's law, compositor curves; not exported; no component uses them).
- Changeset for the rect morph: verified (present and dismiss on a copy or the element, a duration and easing or a spring, Reduced Motion left to the animator, the eased progress moved with identical values, the timed curve for the pager and the morph).
- Description, invariants: one module apart from the hold and the exit copy, nothing at rest and at most five elements, a listed public-API gap: verified.
- Description, change: the two entry points, the trigger and the tint on the animator, a drop keeping velocity, no shadow, pinch-zoom kept, both gutters, a
noneplacement, caller-named marks,onLayerShownbefore the source's writes,pinrestored, nothing importing the module: verified. - Description, this round's commit list and notes: verified against history and the head.
- Description, local check counts (26 unit cases; 13 browser tests, 2 skipped in WebKit): match the files; not rerun here.
- Description, fixture steps 1 to 6 and unit coverage: verified.
- Description, line counts over the rect-morph pull request: verified exactly.
- Description, scope checkboxes: no public API, verified; no product behavior change, verified for the lift (the included rect-morph commits change the pager only for a retarget in a move's first instant and a 0 ms move).
- Description, history sections, performance numbers and app size: from earlier heads, not checkable here; two history items describe code since removed.
- Files with a note:
docs/architecture/layer-runtime.md(INV15 edit awaiting a decision),packages/core/src/liftFromTrigger/liftFromTrigger.ts(onLayerShowndoc),packages/core/src/liftFromTrigger/README.md(listener wording). - Files clear:
.changeset/lift-module.md,.changeset/motion-morph-path.md,.changeset/motion-rect-morph.md,docs/architecture/react-component-runtime.md,docs/specs/AST-094-touch-presentations/spec.md,packages/core/src/Popover/popoverSurfaceMotion.ts,packages/core/src/SegmentedControl/useSegmentedSelectionMotion.ts,packages/core/src/liftFromTrigger/__tests__/liftFromTrigger.fixture.ts,packages/core/src/liftFromTrigger/__tests__/liftFromTrigger.interaction.browser.spec.ts,packages/core/src/liftFromTrigger/liftFromTrigger.test.ts,packages/core/src/motion/README.md,packages/core/src/motion/__tests__/callerMotionValues.test.ts,packages/core/src/motion/__tests__/motionBundle.ts,packages/core/src/motion/__tests__/rectMorph.interaction.browser.spec.ts,packages/core/src/motion/morphPath.test.ts,packages/core/src/motion/morphPath.ts,packages/core/src/motion/paging.test.ts,packages/core/src/motion/paging.ts,packages/core/src/motion/progress.test.ts,packages/core/src/motion/progress.ts,packages/core/src/motion/rectMorph.test.ts,packages/core/src/motion/rectMorph.ts,packages/core/src/motion/themeTiming.server.test.ts,packages/core/src/motion/themeTiming.test.ts,packages/core/src/motion/themeTiming.ts,scripts/snap-paging-bundle.test.mjs.
The lift adds no document listener: it listens on its own layer and on the window's input stream, so the README says its listeners end with it. The onLayerShown doc says presentSurface, drop and dispose do nothing inside it, since the lift records its state once it returns. Comments and docs only.
There was a problem hiding this comment.
Needs an engineering owner's decision on one record edit, plus one fix. Approval waits on an engineering owner deciding this branch's architecture:layer-runtime INV15 edit, which removes “the exit, played through the runtime's exit copy (INV14)” from the lift module, says a surface beside the lift keeps its own exit, and names createLiftFromTrigger and surfacePlacement as its entry points: an engineering owner records that decision by commenting /approve-spec <full head SHA> on this pull request (the author may, as an engineering owner), or else the exit-copy path comes back or the INV15 edit leaves the branch. CI has not run on this head because it is a draft from a fork; once it is ready for review, a maintainer adds the ci:run label so CI runs. This pull request was reviewed on its own, since #9764, #9769, #8485 and #8201 carry different Stack lines.
Blocking:
- Miss: lifting the last row of a list rounded by
li:last-childsquares its bottom corners for as long as it is lifted, because the placeholder becomes the row's next sibling andKEPT_PROPERTIESinliftFromTrigger.tspins no border radius; pinning the fourborder-*-radiuslonghands as laid out, with a look proof that lifts the fixture's last row, fixes it.
Claims and files checked
- Changeset for the lift module: verified (the trigger lifts above a tint, a surface fades in on the rect morph, translate, scale and opacity only, nothing at rest, three elements while lifted, no shadow, not exported, no component uses it).
- Changeset for the morph paths: verified (straight and edge-growth paths, an interrupted motion continuing in each path's law, compositor curves; not exported; no component uses them).
- Changeset for the rect morph: verified (present and dismiss on a copy or the element, a duration and easing or a spring, Reduced Motion left to the animator, the eased progress moved with identical values, the timed curve for the pager and the morph).
- Description, invariants (one module apart from the hold and the exit copy, nothing at rest and at most five elements, a listed public-API gap): verified.
- Description, change (the two entry points, the trigger and the tint on the animator, a drop keeping velocity, no shadow, pinch-zoom kept, both gutters, a
noneplacement, caller-named marks,onLayerShownbefore the source's writes,pinrestored, nothing importing the module): verified; the lifted trigger keeps its look except where that look depends on being the last child (blocking finding). - Description, this round's commit list and notes: verified against the history and the head.
- Description, local check counts (26 unit cases; 13 browser tests, 2 skipped in WebKit): match the files; not rerun here.
- Description, fixture steps 1 to 6 and unit coverage: verified.
- Description, line counts over the rect-morph pull request: verified exactly.
- Description, scope checkboxes: no public API, verified; no product behavior change, verified for this pull request's own commits (the included rect-morph commits change the pager only for a retarget in a move's first instant).
- Description, history sections, performance numbers and app size: from earlier heads, not checkable here.
- Files with a finding:
docs/architecture/layer-runtime.md(INV15 edit awaiting a decision),packages/core/src/liftFromTrigger/liftFromTrigger.ts(last-row radius),packages/core/src/liftFromTrigger/__tests__/liftFromTrigger.interaction.browser.spec.ts(the look proof lifts only the middle row). - Files clear:
.changeset/lift-module.md,.changeset/motion-morph-path.md,.changeset/motion-rect-morph.md,docs/architecture/react-component-runtime.md,docs/specs/AST-094-touch-presentations/spec.md,packages/core/src/Popover/popoverSurfaceMotion.ts,packages/core/src/SegmentedControl/useSegmentedSelectionMotion.ts,packages/core/src/liftFromTrigger/README.md,packages/core/src/liftFromTrigger/__tests__/liftFromTrigger.fixture.ts,packages/core/src/liftFromTrigger/liftFromTrigger.test.ts,packages/core/src/motion/README.md,packages/core/src/motion/__tests__/callerMotionValues.test.ts,packages/core/src/motion/__tests__/motionBundle.ts,packages/core/src/motion/__tests__/rectMorph.interaction.browser.spec.ts,packages/core/src/motion/morphPath.test.ts,packages/core/src/motion/morphPath.ts,packages/core/src/motion/paging.test.ts,packages/core/src/motion/paging.ts,packages/core/src/motion/progress.test.ts,packages/core/src/motion/progress.ts,packages/core/src/motion/rectMorph.test.ts,packages/core/src/motion/rectMorph.ts,packages/core/src/motion/themeTiming.server.test.ts,packages/core/src/motion/themeTiming.test.ts,packages/core/src/motion/themeTiming.ts,scripts/snap-paging-bundle.test.mjs.
The fixture rounds its last row through li:last-child. Lifted, that row must keep its corners, though the placeholder after it ends the last-child match.
The placeholder after the lifted source ends a :last-child match, so a grouped list's last row rose with square bottom corners. The lift now keeps the four corner radii as laid out, with the borders and padding it already keeps.
There was a problem hiding this comment.
Needs an engineering owner's decision on one record edit; the last-row radius fix holds and no blocking defect remains.
Approval waits on an engineering owner deciding this branch's architecture:layer-runtime INV15 edit, which removes “the exit, played through the runtime's exit copy (INV14)” from the lift module, says a surface beside the lift keeps its own exit, and names createLiftFromTrigger and surfacePlacement as its entry points: an engineering owner records that decision by commenting /approve-spec <full head SHA> on this pull request (the author may, as an engineering owner), or else the exit-copy path comes back or the INV15 edit leaves the branch. CI has not run on this head because it is a draft from a fork; once it is ready for review, a maintainer adds the ci:run label so CI runs. This pull request was reviewed on its own, since #9764, #9769, #8485 and #8201 carry different Stack lines.
Claims and files checked
- Changeset for the lift module: verified (the trigger lifts above a tint, a surface fades in on the rect morph, translate, scale and opacity only, nothing at rest, three elements while lifted, no shadow, not exported, no component uses it).
- Changeset for the morph paths: verified (straight and edge-growth paths, an interrupted motion continuing in each path's law, compositor curves; not exported; no component uses them).
- Changeset for the rect morph: verified (present and dismiss on a copy or the element, a duration and easing or a spring, Reduced Motion left to the animator, the eased progress moved with identical values, the timed curve for the pager and the morph).
- Description, invariants (one module apart from the hold and the exit copy, nothing at rest and at most five elements, a listed public-API gap): verified.
- Description, change (the two entry points, the trigger and the tint on the animator, a drop keeping velocity, no shadow, pinch-zoom kept, both gutters, a
noneplacement, caller-named marks,onLayerShownbefore the source's writes,pinrestored, nothing importing the module): verified. - Description, this round's commit list, including the red-first last-row case and the corner fix: verified against the history and the head.
- Description, local check counts (26 unit cases; 14 browser tests, 2 skipped in WebKit): match the files; not rerun here.
- Description, fixture steps 1 to 7 and unit coverage: verified.
- Description, line counts over the rect-morph pull request: verified exactly.
- Description, scope checkboxes: no public API, verified; no product behavior change, verified for this pull request's own commits (the included rect-morph commits change the pager only for a retarget in a move's first instant).
- Description, history sections, performance numbers and app size: from earlier heads, not checkable here.
- File with a finding:
docs/architecture/layer-runtime.md(INV15 edit awaiting a decision). - Files clear:
.changeset/lift-module.md,.changeset/motion-morph-path.md,.changeset/motion-rect-morph.md,docs/architecture/react-component-runtime.md,docs/specs/AST-094-touch-presentations/spec.md,packages/core/src/Popover/popoverSurfaceMotion.ts,packages/core/src/SegmentedControl/useSegmentedSelectionMotion.ts,packages/core/src/liftFromTrigger/README.md,packages/core/src/liftFromTrigger/__tests__/liftFromTrigger.fixture.ts,packages/core/src/liftFromTrigger/__tests__/liftFromTrigger.interaction.browser.spec.ts,packages/core/src/liftFromTrigger/liftFromTrigger.test.ts,packages/core/src/liftFromTrigger/liftFromTrigger.ts,packages/core/src/motion/README.md,packages/core/src/motion/__tests__/callerMotionValues.test.ts,packages/core/src/motion/__tests__/motionBundle.ts,packages/core/src/motion/__tests__/rectMorph.interaction.browser.spec.ts,packages/core/src/motion/morphPath.test.ts,packages/core/src/motion/morphPath.ts,packages/core/src/motion/paging.test.ts,packages/core/src/motion/paging.ts,packages/core/src/motion/progress.test.ts,packages/core/src/motion/progress.ts,packages/core/src/motion/rectMorph.test.ts,packages/core/src/motion/rectMorph.ts,packages/core/src/motion/themeTiming.server.test.ts,packages/core/src/motion/themeTiming.test.ts,packages/core/src/motion/themeTiming.ts,scripts/snap-paging-bundle.test.mjs.
INV15 names the lift module's four functions and why one module serves every surface that lifts. Records only.
|
/approve-spec aa2f8e5 |
|
Decision: D-20261112-210 |
There was a problem hiding this comment.
Approved pending CI: CI has not run on this head yet. This is still a draft from a fork, so once it is marked ready for review, a maintainer adds the ci:run label so CI runs.
The lift-from-trigger module follows the layer runtime's one-module rule, and the rewritten INV15 (a surface beside the lift keeps its own exit; the module's four functions) carries an engineering owner's spec approval for this head. The earlier findings on the repeated drop, the last row's corners and the merge conflicts with main are fixed, and no blocking finding remains.
Non-blocking:
- This pull request was reviewed on its own: its Stack line differs from the one #9764 and #9769 carry, and this branch does not contain their current heads, so merging #9769's head and one identical Stack line in all four bodies would keep the branches from drifting.
Claims and files checked
- Changeset (lift): one opt-in lift for touch surfaces; the trigger rises above a tint, a surface fades in beside it on the shared rect morph, and the trigger returns. Verified:
liftFromTrigger.tslift,presentSurface,drop. - Changeset (lift): translate, scale and opacity only; nothing at rest, three elements while lifted, no shadow. Verified: the motion-properties and element-count browser cases and the unit count; the tint's colour is a zero-length hold, not a motion.
- Changeset (lift, paths, morph): not exported from the package entry point, no component uses it yet. Verified: Core's exports and index are unchanged and nothing imports the modules outside their tests.
- Changeset (paths): the straight line and the popover's edge growth give the rect at each progress and continue an interrupted motion in their own law;
morphCurvesmakes compositor curves. Verified:morphPath.tsand the popover turn-around unit case. - Changeset (morph): present along a path, dismiss on a copy or on itself, each continuing the other; timing is a duration and easing or a spring from a given velocity; Reduced Motion is the animator's. Verified:
rectMorph.tsand its unit cases. - Changeset (morph):
easedProgressmoves with the same values;timedCurvekeeps a retargeted velocity for the pager and the morph. Verified: the bit-identical comparison test,paging.ts,rectMorph.ts. - Description: the invariants it serves (one lift module; minimal DOM with at most five more elements while open; internal use of a listed gap). Verified against the current records.
- Description: the trigger rides the rect morph and the tint the layer's backdrop channel; a drop while either rises keeps its velocity. Verified:
createRectMorph(source), the backdrop animator, the tint turn-around browser case. - Description: no shadow, page pinch-zoom kept, the lift fits between the gutters on both axes, placement can answer none. Verified: the layer's
touch-action,liftFromTriggerScale,surfacePlacementand their tests. - Description: the caller names the marks, can show its surface once the layer shows, and can pin styles. Verified: the required attribute option, the onLayerShown call before the source's writes, the pin option and their unit cases.
- Description: nothing imports the module; no public API or product behavior changes. Verified (the pager's change is nil on its default curve).
- Description: this round's commit list. Verified: every listed commit is present with a matching subject; the last one changes only the INV15 record.
- Description: unit and browser case counts (26; 14 in Chromium, 12 plus 2 skipped in WebKit) and the line counts over the rect morph branch. Verified by reading the suites and the numstat; the runs themselves were not repeated.
- Description: fixture steps 1 to 7 and the unit coverage list. Verified: each step has its browser case; the unit file covers each listed area.
- Description: performance numbers, app-size numbers and history from earlier heads and other pull requests. Not checkable at this head; no claim of this head depends on them.
.changeset/lift-module.md: clear; claims verified.changeset/motion-morph-path.md: clear; claims verified.changeset/motion-rect-morph.md: clear; claims verifieddocs/architecture/layer-runtime.md: clear; INV15 rewrite and gaps sentence approved for this head, consistent with the moduledocs/architecture/react-component-runtime.md: clear; the gap note states the glide still plays its own translate, which it doesdocs/specs/AST-094-touch-presentations/spec.md: clear; the new verification path existspackages/core/src/Popover/popoverSurfaceMotion.ts: clear; import moved, two internal exports for the morph proofspackages/core/src/SegmentedControl/useSegmentedSelectionMotion.ts: clear; import moved, values unchangedpackages/core/src/liftFromTrigger/README.md: clear; matches the module (three elements, four with the shield, no shadow, listeners end with it)packages/core/src/liftFromTrigger/__tests__/liftFromTrigger.fixture.ts: clearpackages/core/src/liftFromTrigger/__tests__/liftFromTrigger.interaction.browser.spec.ts: clear; 14 cases, two skipped in WebKitpackages/core/src/liftFromTrigger/liftFromTrigger.test.ts: clear; 26 casespackages/core/src/liftFromTrigger/liftFromTrigger.ts: clearpackages/core/src/motion/README.md: clearpackages/core/src/motion/__tests__/callerMotionValues.test.ts: clear; compares with copies of the earlier functionspackages/core/src/motion/__tests__/motionBundle.ts: clearpackages/core/src/motion/__tests__/rectMorph.interaction.browser.spec.ts: clearpackages/core/src/motion/morphPath.test.ts: clearpackages/core/src/motion/morphPath.ts: clearpackages/core/src/motion/paging.test.ts: clearpackages/core/src/motion/paging.ts: clear; plays timedCurvepackages/core/src/motion/progress.test.ts: clearpackages/core/src/motion/progress.ts: clearpackages/core/src/motion/rectMorph.test.ts: clearpackages/core/src/motion/rectMorph.ts: clearpackages/core/src/motion/themeTiming.server.test.ts: clearpackages/core/src/motion/themeTiming.test.ts: clear; its cases moved to progress.test.tspackages/core/src/motion/themeTiming.ts: clear; easedProgress moved out, still imported for its own usescripts/snap-paging-bundle.test.mjs: clear; the pager bundle now includes the progress module
Stack: #9764 → #9769 → #8485 → #8201.
Behavior module: the trigger lift (
liftFromTrigger).Maintainer impact
The UIKit-parity program brings iOS 26's touch presentations to Astryx, and two of them lift their trigger: ContextMenu's long-press preview (#8201) and Lightbox's zoom (#8231). Each was building its own copy. ContextMenu's clone mounted the trigger's content twice, as a second React tree. Lightbox kept its own zoom copy. The two motions would drift apart, and the page paid for both.
Intended invariant
architecture:layer-runtimeINV15: one opt-in lift module, apart from the runtime's hold and exit copy.architecture:component-style-authoringINV7 andspec:AST-017FR60: nothing at rest, at most five elements lifted.spec:AST-107FR7: a listed public-API gap, so it stays internal.Change
There were three options. Each surface could keep its own copy, which doubles ContextMenu's tree. A clone of the trigger's DOM loses a React trigger's state and listeners. Or the trigger lifts itself. This takes the third, with an empty placeholder holding its spot:
packages/core/src/liftFromTrigger/liftFromTrigger.tsexposescreateLiftFromTrigger()andsurfacePlacement. Lightbox's copy returns with its first user. Everything moves on the animator: the trigger on #9769's rect morph, and the tint on the layer's::backdropchannel. A drop while either rises turns it with its velocity. The lifted trigger casts no shadow. The lift keeps the page's pinch-zoom (touch-action: pinch-zoomon its layer) and fits between the viewport's gutters on both axes.surfacePlacementreports when a surface fits on neither side (spec:AST-094DEC-19); the layer runtime's fallback is then the caller's path. The caller names the lift's marks with a private attribute it owns, so the module writes none of its own. A caller can show its own surface once the layer shows, before the trigger lifts (onLayerShown). It can pin styles on the lifted trigger, which the lift puts back with its own (pin). Nothing imports the module yet.Evidence
Scope
Testing
This round, at aa2f8e5, over #9769's head 18fcf70. The owners asked for the cleanups, and review asked for the rest. Nothing imports the module yet, so no product behavior changes:
liftCopy,hideSourceandpictureOf, with their types and tests. They return with their first user.dismissSurfaceand its exit-copy path, and the fixture's close.liftFromTrigger.ts, and 0cd53f6 dropsuseLiftFromTrigger.presentSurface's unused press parameter and itssurfaceStartWidthoption.architecture:layer-runtimeINV15 names the entry points and says a surface beside the lift keeps its own exit.attributeoption's doc names the marks the lift sets, its layer, anchor box and placeholder.onLayerShown's doc says it runs before the source's writes, and what the page holds then.onLayerShown's doc sayspresentSurface,dropanddisposedo nothing inside it.li:last-child, and a new case lifts that row. At 4380723 the row rose with square bottom corners, since the placeholder after it ended the last-child match.architecture:layer-runtimeINV15 lists the module's four functions and why one module serves every surface that lifts.Local checks at 8db9bf4, one worker (aa2f8e5 changes one record; check:knowledge passes at it):
test:ui --changed): 1 file, 26 passed, the module's own unit file (nothing else imports it);Restacked onto #9769's head 6b6310c, which holds main's input hold, exit copy, presentation hold and one eased progress. This pull request carries only its own commits:
{spring}motion. The caller names the lift's marks:attributeis required for a lift, and a zoom's copy was marked only when given one, until fc3aaf9 removed the copy. Comments state reasons, not records, in sentences of at most 25 words. The hold proof taps with a finger.The pull requests it carried are merged (#8342, #8186, #8076) or superseded (#8329, by #9764 and #9769).
Main's input hold judges each event by its own pointer, so a mouse keeps its clicks during a presentation. The lift is a touch presentation, so its hold proof taps with a finger. The proofs import Playwright through the interaction harness.
The review rounds add fourteen commits, each test ahead of its fix and red before it:
none(3 units red).transitionProperty, notwidth, so a lift that replaces another lays the page out once. No proof can count layouts from page script.onLayerShownruns once the layer shows, before the source's writes (a unit case pins the order).pintakes them with the lift's own (a unit case pins the restore).Local checks, one worker:
CI=true pnpm lint(0 errors), check:knowledge, check:changesets and test:node (17,544 passed).In the lift fixture (
pnpm test:interaction packages/core/src/liftFromTrigger, Chromium and WebKit):lichildren.li:last-childrounds: it keeps its corners while lifted.The unit tests (
pnpm vitest run packages/core/src/liftFromTrigger) cover the lift's elements, its holds, the restore, a repeated drop and the geometry.Writing rubric results
INV15's closing sentences list the module's four functions and why one module serves every surface that lifts.
R1–R7: no narration, research, evidence-cell changes, rejected alternatives, change references, open questions or project status; the layer-runtime gaps paragraph only states which gaps remain.
Public and internal API delta
Public: none.
Internal, new:
liftFromTrigger/liftFromTrigger.ts, named inarchitecture:layer-runtimeINV15. Nothing imports it yet; #8201 is its first user.createLiftFromTrigger()lifts a source, presents a surface beside it, drops and ends. Usage:const lift = createLiftFromTrigger();.surfacePlacement(lifted, surfaceHeight, viewport, gap)picks the surface's side, or answersnone. Usage:const {side} = surfacePlacement(lifted, menuHeight, viewport, gap);.liftFromTriggerScaleandliftFromTriggerRect, the geometry, are exported for the module's unit tests only.Why: ContextMenu's preview mounted its trigger twice, and Lightbox kept its own copy. One module lifts the trigger itself. Existing ones considered: the layer runtime's hold and exit copy (INV14), which play a layer's own presentation, not a trigger lifted out of the page. #9769's rect morph moves the lift. A clone of the trigger's DOM loses a React trigger's state and listeners (Change). An engineering owner's API decision on the module is pending.
Lines, over #9769's head: product +1,076/−0 (
liftFromTrigger.ts), tests +1,455/−0, README +51/−0, records +14/−8, changesets +7/−0.App-level size, eager JS gzip of the
example-vitepage in a Vite production build, over #9769's head: no change as shipped, with one ContextMenu or with one Switch (+0 B each). Nothing imports the module yet.