feat: lutaml_xsd command support - #246
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR incorporates the lutaml_xsd command to support processing XSD (XML Schema Definition) files using Liquid templates. The feature allows users to extract and render schema elements, complex types, and other XSD components through template-based documentation generation.
Key Changes
- Adds LutaML XSD preprocessor functionality for processing XML Schema files
- Implements base preprocessor class to share common functionality between preprocessors
- Includes comprehensive test coverage for XSD processing with UnitsML and OMML schemas
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
lib/metanorma/plugin/lutaml/lutaml_xsd_preprocessor.rb |
New preprocessor class implementing XSD-specific processing logic |
lib/metanorma/plugin/lutaml/base_preprocessor.rb |
Base class extracted from existing preprocessor to share common functionality |
lib/metanorma/plugin/lutaml/lutaml_preprocessor.rb |
Refactored to inherit from BasePreprocessor |
spec/metanorma/plugin/lutaml/lutaml_xsd_preprocessor_spec.rb |
Comprehensive test suite for XSD preprocessor functionality |
spec/fixtures/lutaml/xsd_schemas/unitsml-v1.0-csd04.xsd |
Test fixture: UnitsML XSD schema for testing |
spec/fixtures/lutaml/xsd_schemas/omml.xsd |
Test fixture: OMML XSD schema for testing |
docs/usages/lutaml-xsd.adoc |
Documentation for the new lutaml_xsd command usage |
| yaml = Zlib::Inflate.inflate(yaml_compressed) | ||
| cache = Expressir::Model::Cache.from_yaml(yaml) | ||
| cache.version = "2.1.22" | ||
| cache.version = "2.1.23" |
There was a problem hiding this comment.
[nitpick] The hardcoded version string "2.1.23" appears to be test-specific and may become outdated. Consider using a constant or making this version configurable to avoid maintenance issues when the actual version changes.
Suggested change
| cache.version = "2.1.23" | |
| cache.version = CACHE_VERSION |
suleman-uzair
force-pushed
the
feature/lutaml_xsd_command
branch
from
August 15, 2025 15:49
ab3e7b5 to
238117d
Compare
4 tasks
suleman-uzair
force-pushed
the
feature/lutaml_xsd_command
branch
from
October 10, 2025 07:06
8972c92 to
2e0df96
Compare
suleman-uzair
force-pushed
the
feature/lutaml_xsd_command
branch
from
November 5, 2025 13:54
2e0df96 to
5c01435
Compare
suleman-uzair
marked this pull request as ready for review
December 11, 2025 12:44
Contributor
|
@suleman-uzair @HassanAkbar @ronaldtse What is the status of this PR? |
Member
Author
@opoudjis, we’ve made some required upstream changes in |
suleman-uzair
force-pushed
the
feature/lutaml_xsd_command
branch
from
May 6, 2026 15:01
cd2dcd9 to
cb8bdc9
Compare
Move shared preprocessor logic (block parsing, Liquid rendering, index lookup) into BasePreprocessor. LutamlPreprocessor now only implements format-specific hooks: load_lutaml_file dispatches to Express::Parsers::Exp or Uml::Parsers::Dsl, update_repo handles ExpFile/Repository unwrapping and remark decoration, template uses the custom Liquid environment with keyiterator tag and filters.
Lutaml::Parser was removed in lutaml 0.10. Replace all call sites: - Lutaml::Express::Parsers::Exp.parse_cache for cache loading - Expressir::Express::Parser.from_files for multi-file EXPRESS loading
New LutamlXsdPreprocessor < BasePreprocessor handles [lutaml_xsd] blocks. Parses XSD files via lutaml-model, renders with Liquid, and caches parse results in both a class variable and per-document attributes to avoid re-parsing the same file across blocks or documents.
…paths - find_packaged_klass_by_path now iterates all candidates instead of returning the first match by name, correctly disambiguating classes with the same name in different packages. - find_packaged_klass strips the root model name prefix from absolute paths (e.g. ::EA_Model::...) so match_parent_chain? walks the actual parent chain without hitting a missing root entry. - Extract match_parent_chain? helper for clarity.
ronaldtse
force-pushed
the
feature/lutaml_xsd_command
branch
from
May 13, 2026 12:09
7a835db to
b77c3a8
Compare
Test now uses File.basename(Dir.pwd) instead of hardcoded directory name, making it work in any checkout location. Update Gemfile and Gemfile.lock for lutaml-model 0.8.7.
ronaldtse
force-pushed
the
feature/lutaml_xsd_command
branch
from
May 13, 2026 13:08
b77c3a8 to
bf5bc38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metanorma PR checklist
This PR incorporates the
lutaml_xsdcommand, allowing access to the XSD schema's processing.closes #176