feat: add XSD direct block syntax and UnitsML fixture specs - #271
Merged
Conversation
Add lutaml_xsd::path[context, template, options] direct block syntax to LutamlXsdPreprocessor, enabling external Liquid template files for XSD schema rendering. Extract FILE_SYSTEM_PATTERNS constant and build_file_system method into BasePreprocessor for reuse by both block and direct syntax paths. Enable rubygems MFA requirement in gemspec.
Add comprehensive specs covering: - UnitsML schema elements and complex types (block syntax) - OMML schema with location option (block syntax) - Full UnitsML documentation with cross-references (block syntax) - XSD direct block syntax with external Liquid templates - Mixed direct + block syntax in same document - Missing template file error handling Includes expected output XML fixtures for semantic comparison.
This was referenced May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Salvages two features from PR #251 (which was effectively empty — contributor removed their own Liquid filters):
lutaml_xsd::path[context, template, options]) — renders XSD schemas using external Liquid template filesArchitecture
FILE_SYSTEM_PATTERNSconstant andbuild_file_systemmethod extracted intoBasePreprocessorfor reuse by both block and direct syntax paths (DRY, Open/Closed)handle_direct_blockreuses inherited Template Method hooks:load_lutaml_file,template,update_repo,build_file_systemprocess_text_blocksoverride checks for direct syntax before delegating tosuper— clean extension pointSpec coverage (14 examples, 0 failures)
{% render %}tag, missing template error, mixed direct+block syntaxOther changes
.gitignorefor transient files (test.err.html,TODO.cleanup/,pkg/).rubocop_todo.ymlCloses #251