Skip to content

Registered LutamlXsdPreprocessor in Asciidoctor::Extensions - #1086

Merged
opoudjis merged 3 commits into
mainfrom
update/lutaml_xsd_preprocessor_support
Dec 15, 2025
Merged

Registered LutamlXsdPreprocessor in Asciidoctor::Extensions#1086
opoudjis merged 3 commits into
mainfrom
update/lutaml_xsd_preprocessor_support

Conversation

@suleman-uzair

Copy link
Copy Markdown
Member

Metanorma PR checklist

This PR updates the Asciidoctor::Extensions register with LutamlXsdPreprocessor.

related to metanorma/metanorma-plugin-lutaml#177

@opoudjis

Copy link
Copy Markdown
Contributor

@suleman-uzair Update please on this PR

@suleman-uzair

Copy link
Copy Markdown
Member Author

@suleman-uzair Update please on this PR

@opoudjis, I'm working on the comments by @ronaldtse, I will let you know as soon as its finalized.

@suleman-uzair
suleman-uzair force-pushed the update/lutaml_xsd_preprocessor_support branch from 319afcf to 35de9d4 Compare October 10, 2025 08:06
@suleman-uzair
suleman-uzair force-pushed the update/lutaml_xsd_preprocessor_support branch from 35de9d4 to 51879cb Compare November 10, 2025 08:17
@opoudjis

Copy link
Copy Markdown
Contributor

@suleman-uzair Update please

@suleman-uzair

Copy link
Copy Markdown
Member Author

@suleman-uzair Update please

@opoudjis I’m reviewing the implementation. There are multiple PRs for this, so I’ll let you know once I’ve completed my review.

@suleman-uzair
suleman-uzair marked this pull request as ready for review December 11, 2025 12:44
@opoudjis
opoudjis merged commit 290ab3d into main Dec 15, 2025
15 checks passed
@ronaldtse

Copy link
Copy Markdown
Contributor

@opoudjis Just a warning that this merge may break things because there are things in flux on the lutaml side. If it works, great. If it doesn't, comment out this line. Thanks.

PS that's why it's bad to link the code inside here, because there is no gating on whether this extension should be loaded.

@ronaldtse

Copy link
Copy Markdown
Contributor

@opoudjis @suleman-uzair we will need to revert this. I need to test the rest of the chain and there are some updates to make. We cannot let this block release.

@ronaldtse

Copy link
Copy Markdown
Contributor

@opoudjis there is a reason why I did not approve this PR or tell you to merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants