Registered LutamlXsdPreprocessor in Asciidoctor::Extensions - #1086
Conversation
|
@suleman-uzair Update please on this PR |
@opoudjis, I'm working on the comments by @ronaldtse, I will let you know as soon as its finalized. |
319afcf to
35de9d4
Compare
35de9d4 to
51879cb
Compare
|
@suleman-uzair Update please |
@opoudjis I’m reviewing the implementation. There are multiple PRs for this, so I’ll let you know once I’ve completed my review. |
|
@opoudjis Just a warning that this merge may break things because there are things in flux on the lutaml side. If it works, great. If it doesn't, comment out this line. Thanks. PS that's why it's bad to link the code inside here, because there is no gating on whether this extension should be loaded. |
|
@opoudjis @suleman-uzair we will need to revert this. I need to test the rest of the chain and there are some updates to make. We cannot let this block release. |
|
@opoudjis there is a reason why I did not approve this PR or tell you to merge this. |
Metanorma PR checklist
This PR updates the
Asciidoctor::Extensionsregister withLutamlXsdPreprocessor.related to metanorma/metanorma-plugin-lutaml#177