fix(deps): update deps and fix lint rules#389
Merged
Conversation
Replace parseInt with Math.trunc(Number()) and add unicode flag to regex.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 820baaa The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThe PR refreshes workspace tooling versions, updates package manager and peer dependency ranges, and adjusts commitlint branch parsing and ignore rules while recording the patch releases in changesets. ChangesToolchain refresh and commitlint fixes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/commitlint-config/package.json`:
- Around line 47-48: The `@mheob/commitlint-config` update is a breaking peer
dependency change because `CommitlintConfig` now requires `@commitlint/cli`
^21.1.0 instead of v20.x. Update the changeset in
`.changeset/update-dependencies.md` to declare a major release for
`@mheob/commitlint-config` (not a patch), and make sure the changelog/release
notes explicitly mention the `@commitlint/cli` requirement bump.
In `@packages/commitlint-config/src/index.ts`:
- Around line 55-56: The issue is that the issue-prefix check in the commitlint
config accepts non-decimal numeric literals via generic coercion. Update the
logic in the branch/subject parsing path around firstNamePart so it only matches
plain decimal digits before returning the prefixed issue string, instead of
using Math.trunc(Number(firstNamePart)).
In `@packages/oxfmt-config/package.json`:
- Around line 44-45: The peer dependency range change for `@mheob/oxfmt-config` is
a breaking compatibility change because it excludes older oxfmt versions, so
update the changeset entry in update-dependencies.md to a major release (or
minor if following 0.x rules) for the package; if the lower bound was not
intended, relax the peerDependencies range in package.json instead. Use the
`@mheob/oxfmt-config` package entry and the update-dependencies changeset as the
places to align the version bump with the new peer constraint.
In `@packages/oxlint-config/package.json`:
- Line 54: The oxlint peer dependency floor was raised in the package.json
peerDependencies entry, which is a breaking compatibility change and should not
ship in a patch release. Update the oxlint range in the package manifest either
by widening it back to the previous compatible floor if possible, or by ensuring
the package version/release is bumped to a minor or major release to match the
breaking change; use the oxlint peerDependencies entry in package.json to locate
it.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 84166f5f-766f-494b-8cf1-ce902da16a42
⛔ Files ignored due to path filters (1)
bun.lockis excluded by!**/*.lock
📒 Files selected for processing (8)
.changeset/fix-commitlint-oxlint-rules.md.changeset/update-dependencies.mdpackage.jsonpackages/commitlint-config/package.jsonpackages/commitlint-config/src/index.tspackages/internal/package.jsonpackages/oxfmt-config/package.jsonpackages/oxlint-config/package.json
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update all non-major dependencies and fix oxlint rule violations in commitlint-config.
Changes
@commitlint/clifrom ^20.5.3 to ^21.1.0oxfmtfrom ^0.53.0 to ^0.56.0 andoxlintfrom ^1.68.0 to ^1.71.0turbo,tsdown,lint-staged,@types/node, and ESLint pluginsbunpackageManager from 1.3.11 to 1.3.14@commitlint/cli,oxfmt, andoxlintparseIntwithMath.trunc(Number())in commitlint-confignode/no-synclint ruleMotivation
Keep tooling current and resolve new oxlint rule violations introduced by the updated linter version.
Summary by CodeRabbit
Bug Fixes
Chores