Skip to content

opentimsr: crash/segfault when downloading bruker.so twice #21

Closed

Description

@sneumann

Hi,
the following code will reproducibly crash your R session:

library(opentimsr)
so_folder <- tempdir()

so_file <- download_bruker_proprietary_code(so_folder, method = "wget")
setup_bruker_so(so_file)

so_file <- download_bruker_proprietary_code(so_folder, method = "wget")
setup_bruker_so(so_file)

My guess is that R doesn't like it if a used *.so gets overwritten.
=> Possibly this can be solved if download_bruker_proprietary_code() refuses to overwrite the file.
More complex would probably be to check to not overwrite a loaded *.so file.

Yours,
Steffen

Activity

  1. michalsta commented on Jul 10, 2023

    @michalsta
    Owner

    Hi,

    What would be the use-case and expected behaviour of such code? In other words, what are you trying to do here? Because I'm kind of tempted to respond with a "yeah, don't do that then" ;)

    Though of course that should be a proper error message, not a segfault.

  2. sneumann commented on Jul 10, 2023

    @sneumann
    ContributorAuthor

    "Don't do that" is exactly the correct answer. It was an oversight, we learned that now :-)
    But with the check it would be more robust, so indeed very low on the priority list. Yours, Steffen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions