[Agent Archiving] Payables and Expense agent implementation for IAgentArchiving

[krupybalu]

What & why

Honours the new IAgentArchiving interface, and opts Payables Agent and Expense Agent out of archiving.

The Archive action is disabled on the Agent List and Agent Card for agent types that do not support archiving, and Agent.Archive blocks it programmatically so the guard cannot be bypassed. The check runs off the record the pages already hold, so it costs no extra read and cannot fail on an unsaved record.

Payables and Expense opt out via their own PA Agent Archiving / EA Agent Archiving codeunits, mirroring how each app already registers IAgentTaskExecution, so they can be removed cleanly once each agent supports archiving. Both are single-instance: the setup record enforcing that is left behind by archiving, which would block creating a replacement.

Behaviour is unchanged for every agent type that does not opt out.

Linked work

AB#647379

Related PRs

Cross-repo change - merge in this order:

1. BC-Platform - the interface: https://microsoft.ghe.com/bic/BC-Platform/pull/46005
2. BCApps - System App honours it, Payables and Expense opt out (this PR): [Agent Archiving] Payables and Expense agent implementation for IAgentArchiving #10460

Note: this PR will not build until 1 is merged and a platform version carrying IAgentArchiving flows through.

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Error\ Handling}$

AgentImpl.IsArchivingSupported(Agent) (local overload) does AgentArchiving := Agent."Agent Metadata Provider"; exit(AgentArchiving.IsArchivingSupported());, which requires every enum value of "Agent Metadata Provider" to implement IAgentArchiving. Confirmed by inspecting the current enum extensions: the default "SDK Mock Agent" value (MockAgentMetaProv.EnumExt.al), "SO Agent" (SOAMetadataProvider.EnumExt.al) and "Custom Agent" (CustomAgentMetadataProvider.EnumExt.al) do NOT declare an IAgentArchiving implementation. Casting such a value to the IAgentArchiving interface variable raises an unhandled AL runtime error ("enum value does not implement interface") instead of returning a Boolean. This directly contradicts the new test assertion added in the same PR, Assert.IsTrue(Agent.IsArchivingSupported(AgentId), 'Archiving should be supported for a type that does not opt out') in AgentTest.Codeunit.al (ArchiveDisabledAgentSetsArchived, ~line 997), which calls IsArchivingSupported on an agent created via GetOrCreateDefaultAgent — i.e. an "SDK Mock Agent" — and expects true, but the call will error instead. The same crash risk applies in production to the AgentCard/AgentList archive actions for SO Agent and Custom Agent users. Add an explicit guard (e.g. check whether the interface is implemented, or default to a Boolean via a safe pattern) so agent types that have not opted into IAgentArchiving return a sane default instead of throwing.

_{Agent judgement — not directly backed by a BCQuality knowledge article.}

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.35.4}

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Style}$

The changed file src/System Application/Test/Agent/src/Setup/LibraryMockAgent.codeunit.al does not follow the <ObjectName>.<ObjectType>.al convention from the style guidance: the type segment is written as codeunit instead of Codeunit. Rename it to LibraryMockAgent.Codeunit.al so file listings and tooling can map the object name and type reliably.

Knowledge:

• microsoft/knowledge/style/file-name-object-type-pattern.md

Line mapping was unavailable, so this was posted as an issue comment.

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.35.4}

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Testing}$

This negative test follows asserterror with Assert.ExpectedError, but it only matches the generic substring is not supported. That is broad enough that an unrelated failure with the same wording could still make the test pass without proving the unsupported-archiving guard fired. Assert a more specific invariant fragment of the message (and the error code if known).

Knowledge:

• microsoft/knowledge/testing/asserterror-needs-expectederror-and-code.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.35.4}