MSlenejennum/647452/new header and footer layouts and report themes

[MSlenejennum]

AB#647452

Seed shipped header/footer and report theme parts on install and upgrade

Adds the out-of-box Composite Layout parts (11 header/footer designs, 3 themes) and the
install/upgrade pass that writes them into the shared pool under Tenant Report Defaults. The page
and lookup helper are already in main; this supplies their content.

New: codeunit 9667 "Composite Report Parts Mgt.", codeunit 104064 "Upgrade Composite Report Parts", 14 resources under .resources/ReportParts/.
Changed: BaseAppInstall seeds on install; UpgradeTagDefinitions (W1/BE/IT/RU) registers the
per-database tag; CompositeLayoutTests now 42 tests.

Behaviour

• Parts are stored under this app's own App ID, resolved via NavApp.GetCurrentModuleInfo. That ID
  is part of the Tenant Report Layout key and of the <guid>::<name> reference every assignment
  stores.
• Seeding deletes and re-inserts, because the platform will not let an existing layout's type and
  content be modified.
• The pass is not gated by its upgrade tag — it runs on every upgrade and overwrites tenant edits
  to the shipped parts. Deliberate: these are app content, not tenant data. Copy a part to make a
  variant.
• A part the app no longer ships is removed and its assignments cleared, so dropping a SeedPart
  call actually takes it out of the pool.
• A part whose resource cannot be read is logged to telemetry and skipped, not raised — an uncaught
  error here would abort install or upgrade.

[MSlenejennum]

Look through

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Telemetry}$

The publisher-only detail event logs raw ErrorText after explicitly noting that platform error text can echo customer content, but the event is still classified as DataClassification::SystemMetadata. Reclassify that payload to a customer-data classification that matches the possible content, or stop emitting the raw error text and keep only sanitized metadata.

Line mapping was unavailable, so this was posted as an issue comment.

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.35.4}

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Agent}$

The new shipped theme resource src/Layers/W1/BaseApp/.resources/ReportParts/ReportTheme/Playful.dotx is 5.46 MB, roughly 97x larger than its sibling themes Default.dotx and Calm.dotx (~56 KB each). Unzipping it shows a single word/media/image1.png accounting for 5.41 MB of the file, almost certainly an uncompressed or excessively high-resolution background image. Because CompositeReportPartsMgt.SeedDefaultParts seeds this resource into every tenant/company's Tenant Report Layout table on install and upgrade, the bloat is baked into every customer's database, inflates the app package size shipped to every tenant, and slows install/upgrade seeding. Re-export/compress the source image (e.g. downsample and use PNG/JPEG compression appropriate for a print/report background) before shipping, and add a size sanity check to the theme-authoring process.

Line mapping was unavailable, so this was posted as an issue comment.

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.35.4}

[github-actions]

$\textbf{🟠\ High\ Severity\ —\ Performance}$

ClearTestReportLayouts iterates Tenant Report Layout filtered only on "Report ID" to queue the primary key into a temporary buffer for later deletion, but it does not call SetLoadFields before FindSet(), so it still materializes every field of each matched layout row (including the large Layout blob) just to read the key. Add SetLoadFields("Report ID", Name) before FindSet() so the loop loads only the key fields it actually uses.

Suggested fix (apply manually — could not be anchored as a one-click suggestion):

        TenantReportLayout.SetLoadFields("Report ID", Name);
        TenantReportLayout.SetRange("Report ID", BodyReportID);
        if TenantReportLayout.FindSet() then

Knowledge:

• microsoft/knowledge/performance/load-only-primary-key-fields-for-reference-work.md

Line mapping was unavailable, so this was posted as an issue comment.

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.35.4}

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Other}$

GetCompositeReportPartsUpgradeTag() (added to UpgradeTagDefinitions in W1/BE/IT/RU) is never added to the RegisterPerDatabaseTags list (the [EventSubscriber] on Codeunit::"Upgrade Tag", 'OnGetPerDatabaseUpgradeTags') in src/Layers/W1/BaseApp/OtherCapabilities/Upgrade/UpgradeTagDefinitions.Codeunit.al, unlike every other per-database upgrade tag defined in that file (e.g. GetNewISVPlansUpgradeTag, GetSharePointConnectionUpgradeTag, etc., all of which are registered). That registration list is what the platform uses to mark tags as already-applied for brand-new installations, so upgrade logic tied to them does not redundantly run for a tenant that never needed the migration. Because 'Upgrade Composite Report Parts' is Subtype = Upgrade with OnUpgradePerDatabase, omitting the registration is inconsistent with the established pattern for every sibling tag in this same file and should be reviewed for correctness (does the platform's automatic per-database tag pre-seeding on install rely on this list to avoid a redundant SeedShippedParts() re-run through a later upgrade pass?).

Line mapping was unavailable, so this was posted as an issue comment.

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.35.4}

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Performance}$

ClearTestReportLayouts iterates "Tenant Report Layout" without SetLoadFields before FindSet, so every field of every row is materialized even though only Name is read before the row is re-fetched for deletion.

Suggested fix (apply manually — could not be anchored as a one-click suggestion):

        TenantReportLayout.SetRange("Report ID", BodyReportID);
        TenantReportLayout.SetLoadFields(Name);
        if TenantReportLayout.FindSet() then

Knowledge:

• microsoft/knowledge/performance/use-setloadfields-for-partial-records.md

Line mapping was unavailable, so this was posted as an issue comment.

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.35.4}