Skip to content

MSlenejennum/647454/sales internal new body layouts and obsolete current #10495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MSlenejennum wants to merge 9 commits into
base: main
Choose a base branch
from
Open

MSlenejennum/647454/sales internal new body layouts and obsolete current #10495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b5c194d
Add composite Body layouts for three Sales reports and obsolete the c…
MSlenejennum Aug 21, 2026
b4cbc6d
Replace the three Sales report layouts with the versions from feature…
MSlenejennum Aug 21, 2026
507e326
Merge branch 'main' of https://github.com/microsoft/BCApps into MSlen…
MSlenejennum Aug 21, 2026
37f04d2
Moved to smaller slice
MSlenejennum Aug 21, 2026
a0d0a21
Merge branch 'main' of https://github.com/microsoft/BCApps into MSlen…
MSlenejennum Aug 22, 2026
ca9caa6
Updated layout
MSlenejennum Aug 23, 2026
5a18201
Invoke mi-app
MSlenejennum Aug 24, 2026
2870039
Merge branch 'main' of https://github.com/microsoft/BCApps into MSlen…
MSlenejennum Aug 24, 2026
e2f7ac0
Trying to implement changes
MSlenejennum Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions src/Layers/APAC/BaseApp/Sales/Reports/SalespersonSalesStatistics.Report.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,12 +151,40 @@ report 114 "Salesperson - Sales Statistics"

rendering
{
layout(ExcelLayout)
{
Caption = 'Salesperson Sales Statistics Excel';
Comment thread
MSlenejennum marked this conversation as resolved.

@qasimikram Qasim (qasimikram) Aug 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Existing APAC layout name changed from RDLC to Excel. The layout RDLCLayout was RDLC and now becomes Type = Excel with an .xlsx file, and a new layout named RDLC is added. Report 114 still has DefaultRenderingLayout = RDLCLayout, so APAC users get Excel output by default instead of RDLC, and any saved layout selection that points to RDLCLayout also switches. Please keep RDLCLayout as the RDLC layout and add only the new body layout.

Type = Excel;
LayoutFile = './Sales/Reports/SalespersonSalesStatistics.xlsx';
Summary = 'Report layout primarily made for data analysis. Use an Excel editor to modify the layout.';
}
#if not CLEAN30

@github-actions github-actions Bot Aug 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$\textbf{🟠\ High\ Severity\ —\ Breaking\ Changes}$

The APAC variant of "Salesperson - Sales Statistics" (report 114) previously had only an RDLCLayout; this PR introduces a brand-new layout(Word) wrapped in #if not CLEAN30 and marks it ObsoleteState = Pending at the moment of its introduction. This ships new report-layout behavior that is already scheduled for removal: any tenant setup, report selection, or extension that starts depending on this Word layout before CLEAN30 flips is being pointed at a transient, already-deprecated contract with no real usable lifetime. Prefer shipping only the supported Excel/WordBody layouts here, or introduce the Word layout without the immediate obsoletion if it needs a real (non-transient) lifetime.

Knowledge:

👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.35.4

layout(Word)
{
Caption = 'Salesperson Sales Statistics Word';
Type = Word;
LayoutFile = './Sales/Reports/SalespersonSalesStatistics.docx';
Summary = 'Report layout made for print. Use a Word editor to modify the layout.';
ObsoleteState = Pending;
ObsoleteReason = 'This Word layout will be replaced by the Document Report Experience. Use the corresponding composite (body) layout instead. It will be removed in a future release.';
ObsoleteTag = '30.0';
#endif
}
layout(RDLCLayout)
{
Caption = 'Salesperson Sales Statistics RDLC';
Type = RDLC;
LayoutFile = './Sales/Reports/SalespersonSalesStatistics.rdlc';
Summary = 'Report layout made in the legacy RDLC format. Use an RDLC editor to modify the layout.';
}
layout(WordBody)
{
Type = Word;
Subtype = Body;
LayoutFile = './Sales/Reports/SalespersonSalesStatisticsBody.docx';
Caption = 'Body-only: Salesperson Sales Statistics Word';
Summary = 'Landscape orientated. Shows sales, profit, and adjusted profit in LCY and as a percentage for each salesperson, together with invoice discount, payment discount given, and payment tolerance. Includes column totals.';
}
}

labels
Expand Down
11 changes: 11 additions & 0 deletions src/Layers/RU/BaseApp/Sales/Reports/CustomerOrderSummary.Report.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,6 +468,9 @@ report 107 "Customer - Order Summary"
LayoutFile = '.\Sales\Reports\CustomerOrderSummary.docx';
Type = Word;
Summary = 'Built in layout for the Customer Order Summary word report.';
ObsoleteState = Pending;

@qasimikram Qasim (qasimikram) Aug 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obsoleted Word layout is still referenced, so Clean builds fail. RU report 107 keeps DefaultRenderingLayout = Word while this PR marks that Word layout ObsoleteState = Pending. The Clean pipelines for about 20 countries fail with AS0105 The ReportLayout 'Word' cannot be referenced ... ObsoleteTag '30.0'. Please move the default to a layout that is not obsolete, so no object references the obsoleted layout.

ObsoleteReason = 'This Word layout will be replaced by the Document Report Experience. Use the corresponding composite (body) layout instead. It will be removed in a future release.';
ObsoleteTag = '30.0';
}
#if not CLEAN27
layout(RDLC)
Expand All @@ -481,6 +484,14 @@ report 107 "Customer - Order Summary"
Summary = 'Report layout made in the legacy RDLC format. Use an RDLC editor to modify the layout.';
}
#endif
layout(WordBody)
{
Type = Word;
Subtype = Body;
LayoutFile = '.\Sales\Reports\CustomerOrderSummaryBody.docx';
Caption = 'Body-only: Customer Order Summary Word';
Summary = 'Landscape orientated. Groups outstanding sales order amounts by customer and currency, split across the periods before, within, and after the date range. Shows a total for each line and overall totals, in LCY.';
}
}
labels
{
Expand Down
11 changes: 11 additions & 0 deletions src/Layers/W1/BaseApp/Sales/Reports/CustomerOrderSummary.Report.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,6 +467,9 @@ report 107 "Customer - Order Summary"
LayoutFile = '.\Sales\Reports\CustomerOrderSummary.docx';
Type = Word;
Summary = 'Built in layout for the Customer Order Summary word report.';
ObsoleteState = Pending;
ObsoleteReason = 'This Word layout will be replaced by the Document Report Experience. Use the corresponding composite (body) layout instead. It will be removed in a future release.';
ObsoleteTag = '30.0';
}
#if not CLEAN27
layout(RDLC)
Expand All @@ -480,6 +483,14 @@ report 107 "Customer - Order Summary"
Summary = 'Report layout made in the legacy RDLC format. Use an RDLC editor to modify the layout.';
}
#endif
layout(WordBody)
{
Type = Word;
Subtype = Body;
LayoutFile = '.\Sales\Reports\CustomerOrderSummaryBody.docx';
Caption = 'Body-only: Customer Order Summary Word';
Summary = 'Landscape orientated. Groups outstanding sales order amounts by customer and currency, split across the periods before, within, and after the date range. Shows a total for each line and overall totals, in LCY.';
}
}
labels
{
Expand Down
Binary file added src/Layers/W1/BaseApp/Sales/Reports/CustomerOrderSummaryBody.docx
View file
Open in desktop
Binary file not shown.
11 changes: 11 additions & 0 deletions src/Layers/W1/BaseApp/Sales/Reports/SalespersonCommission.Report.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,6 +456,9 @@ report 115 "Salesperson - Commission"
Type = Word;
LayoutFile = './Sales/Reports/SalespersonCommission.docx';
Summary = 'Report layout made for print. Use a Word editor to modify the layout.';
ObsoleteState = Pending;
ObsoleteReason = 'This Word layout will be replaced by the Document Report Experience. Use the corresponding composite (body) layout instead. It will be removed in a future release.';
ObsoleteTag = '30.0';
}
#if not CLEAN27
layout(RDLC)
Expand All @@ -469,6 +472,14 @@ report 115 "Salesperson - Commission"
Summary = 'Report layout made in the legacy RDLC format. Use an RDLC editor to modify the layout.';
}
#endif
layout(WordBody)
{
Type = Word;
Subtype = Body;
LayoutFile = './Sales/Reports/SalespersonCommissionBody.docx';
Caption = 'Body-only: Salesperson Commission Word';
Summary = 'Landscape orientated. Lists each entry for a salesperson with posting date, document, and customer number, followed by sales, profit, and adjusted profit with the matching commission amounts. Includes subtotals and totals, in LCY.';
}
}

labels
Expand Down
Binary file added src/Layers/W1/BaseApp/Sales/Reports/SalespersonCommissionBody.docx
View file
Open in desktop
Binary file not shown.
11 changes: 11 additions & 0 deletions src/Layers/W1/BaseApp/Sales/Reports/SalespersonSalesStatistics.Report.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,9 @@ report 114 "Salesperson - Sales Statistics"
Type = Word;
LayoutFile = './Sales/Reports/SalespersonSalesStatistics.docx';
Summary = 'Report layout made for print. Use a Word editor to modify the layout.';
ObsoleteState = Pending;

@qasimikram Qasim (qasimikram) Aug 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description does not match the code. It says ObsoleteTag = '32.0' behind #if not CLEAN32 and that the default rendering layout stays Excel, but the code uses ObsoleteTag = '30.0', has no CLEAN guard, and the RU and APAC defaults are not Excel. Please update the description and confirm the obsolete tag matches the target release.

ObsoleteReason = 'This Word layout will be replaced by the Document Report Experience. Use the corresponding composite (body) layout instead. It will be removed in a future release.';
ObsoleteTag = '30.0';
}
#if not CLEAN27
layout(RDLC)
Expand All @@ -272,6 +275,14 @@ report 114 "Salesperson - Sales Statistics"
Summary = 'Report layout made in the legacy RDLC format. Use an RDLC editor to modify the layout.';
}
#endif
layout(WordBody)
{
Type = Word;
Subtype = Body;
LayoutFile = './Sales/Reports/SalespersonSalesStatisticsBody.docx';
Caption = 'Body-only: Salesperson Sales Statistics Word';
Summary = 'Landscape orientated. Shows sales, profit, and adjusted profit in LCY and as a percentage for each salesperson, together with invoice discount, payment discount given, and payment tolerance. Includes column totals.';
}
}

labels
Expand Down
Binary file added src/Layers/W1/BaseApp/Sales/Reports/SalespersonSalesStatisticsBody.docx
View file
Open in desktop
Binary file not shown.
Loading