Skip to content

[Extensibility Request] issue 30338: expose internal put-away line event - #10518

Merged
Marko Aleksandric (AleksandricMarko) merged 1 commit into
mainfrom
ai-ext-fix/ext_issue-30338
Aug 24, 2026
Merged

[Extensibility Request] issue 30338: expose internal put-away line event#10518
Marko Aleksandric (AleksandricMarko) merged 1 commit into
mainfrom
ai-ext-fix/ext_issue-30338

Conversation

@AleksandricMarko

@AleksandricMarko Marko Aleksandric (AleksandricMarko) commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Summary

Report 7305 calls an event with a warehouse worksheet line while preparing internal put-away lines, preventing extensions from receiving and adjusting the actual source record. This PR raises a dedicated, correctly typed event after the internal put-away dataitem filters are prepared.

Source issue repository: microsoft/AlAppExtensions; issue number: 30338

Changes Made

  • Whse.-Source - Create Document.OnAfterWhseInternalPutAwayLineOnPreDataItem - expose the internal put-away line record to subscribers at the end of the dataitem's OnPreDataItem trigger

Fixes AB#641690

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Agentic PR Review - Round 1

Recommendation: Accept with Suggestions

What this PR does

Report 7305 raised the generic OnBeforeProcessWhseMovWkshLines event inside the Whse. Internal Put-away Line dataitem OnPreDataItem, passing the Whse. Put-away Worksheet Line sibling dataitem record. That sibling has already finished iterating by that point, so subscribers received a stale, wrongly typed worksheet line instead of the internal put-away line. This PR adds a dedicated, correctly typed event OnAfterWhseInternalPutAwayLineOnPreDataItem that exposes the Whse. Internal Put-away Line record.

The new event is well placed (end of OnPreDataItem, after the filters are set) and its name follows the sibling events in this report (OnBeforeWhsePutAwayWorksheetLineOnPreDataItem, OnAfterWhsePutAwayWorksheetLineOnPostDataItem). The type and timing are correct for the stated integration need.

Suggestions

S1 - Removing existing event call may affect subscribers
This change removes the OnBeforeProcessWhseMovWkshLines call from the internal put-away path. That event still fires in the movement worksheet path, but it will no longer fire here. Any existing subscriber that used this call point will stop running for internal put-away. The record it passed here was already stale, so real impact is likely small, but please confirm no subscriber depends on it - or keep the old call next to the new event to stay safe.

Risk assessment and necessity

Risk: Low and contained to report 7305 (W1). The only behavior change is that OnBeforeProcessWhseMovWkshLines no longer fires during internal put-away processing (see S1); the new event body is empty and adds no logic. No posting, quantity, or bin logic changes.

Necessity: Justified. The old event handed subscribers the wrong record type at the wrong time, so extensions could not adjust the internal put-away line. Exposing the correct record through a dedicated event is the right, minimal way to enable the requested extension point.


[AI-PR-REVIEW] version=1 promptVersion=2 system=github pr=10518 round=1 by=alexei-dobriansky at=2026-08-23T00:12:40Z lastSha=c30eaa7e8c0c557f8f612e6410a148a76c40beba reviewKey=93c68d6158f9d7c9f95d75d273bd63b735fa39fa51cd0f6ed94aae03e3fe53bb suggestions=S1@7ea3dee5

Merged via the queue into main with commit d3e56f2 Aug 24, 2026
179 checks passed
@AleksandricMarko
Marko Aleksandric (AleksandricMarko) deleted the ai-ext-fix/ext_issue-30338 branch August 24, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

event-request Team: SCM GitHub request for SCM area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants