Consolidate Expense Agent (Wizard + demo data) into single W1 app

[v-rohangarg20]

Work item: AB#639548

What

Full consolidation of the Expense Agent into the single W1 Expense Agent (Preview) app, covering both the setup logic and the demo data.

Changes

• Setup consolidation: per-country G/L account and category resolution moved into the W1 Create Expense GL Account / Create Expense Categories codeunits with country-aware name/search/fallback logic; per-country ExpenseAgent_<CC> apps removed from build registrations and app.json internalsVisibleTo; per-country event subscribers emptied.
• Demo-data consolidation: removed the per-country demo-data codeunits (CreateExpGLAccount<CC>, CreateExpPostingGrp<CC>, UpdateEmpPostingGrp<CC>, CreateExpCategories<CC>, CreatePostedExpReport<CC>, ExpenseGLAccountNames<CC>, etc.) and route country demo data through the single W1 module.
• Fixes found during per-country UI testing: DK prepayment 26400 / other 05699; AT bank/card/travel/rounding names; NZ prepayment 2510; FR bank 512100 / travel 625100; new-country fallbacks (NL, BE, IT, CH, FI, CZ); and skip the G/L chart re-indent for blank-country (uninitialized/test) companies so localized G/L Account-Indent does not reject the W1 default accounts.

Testing

Verified per country by running each localized web client and checking the Employee/Expense Posting Groups. Create Expense GL Account compiles clean.

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Performance}$

FindExistingExpenseAccount() only consumes GLAccount."No." and GLAccountCategory."Entry No.", but the new helper still materializes full rows on each FindFirst/FindSet. Add SetLoadFields to both record variables; this path is bounded setup code, so keep the severity minor, but the helper is called repeatedly while building the localized account catalog.

Suggested fix (apply manually — could not be anchored as a one-click suggestion):

        GLAccount.SetRange("Account Category", AccountCategory);
        GLAccount.SetRange("Account Type", GLAccount."Account Type"::Posting);
        GLAccount.SetLoadFields("No.");

        GLAccount.SetFilter(Name, SearchDescription);
        if GLAccount.FindFirst() then
            exit(GLAccount."No.");

        GLAccount.SetRange(Name);
        GLAccountCategory.SetRange("Account Category", AccountCategory);
        GLAccountCategory.SetLoadFields("Entry No.");
        GLAccountCategory.SetFilter(Description, SearchDescription);
        if GLAccountCategory.FindSet() then
            repeat
                GLAccount.SetRange("Account Subcategory Entry No.", GLAccountCategory."Entry No.");
                if GLAccount.FindFirst() then
                    exit(GLAccount."No.");
            until GLAccountCategory.Next() = 0;

Knowledge:

• microsoft/knowledge/performance/use-setloadfields-for-partial-records.md
• microsoft/knowledge/performance/admin-and-migration-pages-tolerate-lower-perf.md

Line mapping was unavailable, so this was posted as an issue comment.

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.35.4}

[github-actions]

$\textbf{🟠\ High\ Severity\ —\ Breaking\ Changes}$

The PR marks each country-specific ExpenseEventSubscriberXX codeunit ObsoleteState = Pending, but in the same change it removes the 10 "Expense Agent (Preview) (XX)" apps and 10 "Expense Agent Demo Data (XX)" apps from build/projects.json and build/groups.json, and strips the corresponding dependency/internalsVisibleTo references from src/Apps/W1/ExpenseAgent/app/app.json and src/Apps/W1/ExpenseAgent/demo data/app.json. That collapses the obsoletion warning window to zero: any environment or dependent extension using those published app/object identities loses them immediately at build/deploy time instead of getting a release cycle to migrate, defeating the purpose of the Pending obsoletion.

Knowledge:

• microsoft/knowledge/breaking-changes/deprecate-public-members-with-the-obsolete-lifecycle.md

Line mapping was unavailable, so this was posted as an issue comment.

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.35.4}

[alexei-dobriansky]

Good Sense Reviewer - Round 1

Recommendation: Request Changes

What this PR does

This consolidates Expense Agent setup and demo data into the W1 app. The country-specific account and category logic is moved into shared codeunits, and the demo data module now chooses country behavior at runtime.

The shared setup logic mostly mirrors the removed country subscribers, and the country build checks are green. One packaging part does not fit the obsoletion path: the country app projects are removed from the build while their objects are only marked pending obsolete. That makes the migration window disappear for environments or extensions that still depend on those app identities.

Problem-solution fit

Fit: Partial

The change addresses the requested consolidation and adds the new country demo-data coverage. It also removes the old country apps immediately, which is broader than a safe consolidation step because the pending obsolete markers can no longer be delivered through those apps.

Suggestions

S1 (🔴 High): Keep the obsolete app packages shippable
The country-specific app and demo-data project entries are removed in the same change that marks their objects as pending obsolete. Keep shipping those apps for the obsolete window, or add a clear migration/removal path before deleting the project entries. Otherwise installed tenants and dependent extensions can lose those app identities without a release to move.

S2 (🟠 Moderate): Add coverage for the posting bypass
The new SetIgnoreJournalTemplNameMandatoryCheck call changes the expense report posting path. Add a focused test that posts an expense report without a journal template name and verifies the expected entries. This is a financial posting path, so the intended bypass should be locked down.

Risk assessment and necessity

Risk: The main regression surface is upgrade and packaging for the country-specific Expense Agent apps, plus expense report posting because Expense Report-Post now changes the Gen. Jnl.-Post Line validation mode for every post in this codeunit. No BaseApp publisher dependency was found in this change.

Necessity: Consolidating the country setup and demo data is justified because it removes duplicate country apps and supports the new country dataset from one W1 implementation. The scope is right only if the old app identities have a safe transition path and the posting bypass is covered.

---

[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=10572 round=1 by=alexei-dobriansky at=2026-08-25T12:32:16.9207609Z lastSha=ac5f3cfdee635bea4956a0bc4a63ac6f9875daef reviewKey=f0f122d2403b0da284802ed9161da125bd2c25f635ec258e1a212c3737f8f4bf suggestions=S1@27b16837,S2@3f476bd6