[Shopify] Fix Shpfy Order Totals FB Test posting tests failing in CZ - #10577
Open
Onat Buyukakkus (onbuyuka) wants to merge 1 commit into
Open
[Shopify] Fix Shpfy Order Totals FB Test posting tests failing in CZ#10577Onat Buyukakkus (onbuyuka) wants to merge 1 commit into
Onat Buyukakkus (onbuyuka) wants to merge 1 commit into
Conversation
github-actions
Bot
added
AL: Apps (W1)
Onat Buyukakkus (onbuyuka)
enabled auto-merge
August 24, 2026 21:22
TestPostedSalesInvoiceResolvedAndNavigated and TestNumberOfLinesDrillDownPostedInvoice post a sales invoice. Under the CZ localization posting requires a VAT Period to exist for the posting date, which was missing, so the tests failed CZ-only. Seed the country-specific VAT setup in Initialize() via LibraryERMCountryData.CreateVATData() and UpdateGeneralPostingSetup(), matching the other Shopify posting tests (ShpfyInvoicesTest, ShpfySuggestPaymentTest). These are safe no-ops in W1. Fixes AB#647314 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8b4a78ce-dc75-4c7c-b776-1ca966d5306b
Onat Buyukakkus (onbuyuka)
force-pushed
the
bugs/647314-shpfy-order-totals-cz-vat-period
branch
from
August 24, 2026 21:27
e86439c to
3b3ba6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestPostedSalesInvoiceResolvedAndNavigatedandTestNumberOfLinesDrillDownPostedInvoicein codeunit 139587Shpfy Order Totals FB Testpost a sales invoice. Under the Czech (CZ) localization, posting requires a VAT Period to exist for the posting date, which the test never sets up. As a result the two tests failed CZ-only (VAT Period does not exist for date …—VAT Date Handler CZL.VATPeriodCZLCheck) and were disabled after the BCApps uptake.Fix
Seed the country-specific VAT setup in
Initialize()viaLibraryERMCountryData.CreateVATData()andUpdateGeneralPostingSetup(), matching the other Shopify posting tests (ShpfyInvoicesTest,ShpfySuggestPaymentTest). In the CZ test layerCreateVATData()creates the required VAT Period; both calls are safe no-ops on W1.Test plan
Ran the CZ integration test job (
RunALIntegrationTests_CZ_Extensions): codeunit 139587 passes 10/10, including the two previously-failing posted-invoice tests.Fixes AB#647314