Skip to content

[Bug 638696] Add teaching tip to Effective Permissions page 9852 - #10579

Merged
Onat Buyukakkus (onbuyuka) merged 1 commit into
mainfrom
bugs/638696-effective-permissions-teaching-tip
Aug 28, 2026
Merged

[Bug 638696] Add teaching tip to Effective Permissions page 9852#10579
Onat Buyukakkus (onbuyuka) merged 1 commit into
mainfrom
bugs/638696-effective-permissions-teaching-tip

Conversation

@onbuyuka

@onbuyuka Onat Buyukakkus (onbuyuka) commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

What & why

Page 9852 (Effective Permissions) was missing a teaching tip, so users opening the page got no in-product explanation of what "effective permissions" are or how to use them. This adds the page-level AboutTitle and AboutText properties so the page shows a teaching tip, consistent with the sibling permission pages (e.g. Permission Set by User, Permissions Overview, Permission Sets).

Linked work

Fixes AB#638696

How I validated this

  • I read the full diff and it contains only changes I intended.
  • I built the affected file locally with no new analyzer warnings.
  • I ran the change in Business Central and confirmed it behaves as expected.
  • I added or updated tests for the new behavior, or explained below why none are needed.

What I tested and the outcome

  • Change is limited to two static page metadata properties (AboutTitle/AboutText) on page 9852, mirroring the exact pattern used by neighboring pages in System/Permissions.
  • Verified with the AL compiler (al_getdiagnostics) that EffectivePermissions.Page.al compiles with 0 errors and 0 new warnings after the change. The only diagnostic on the file is a pre-existing warning about SourceTable = Permission being marked for removal, which is unrelated to this change.
  • No tests added: teaching tips are static UI metadata (AboutTitle/AboutText) with no logic to exercise, and sibling permission pages that define the same properties have no dedicated tests.

Risk & compatibility

None. This is a metadata-only addition of a teaching tip; there is no behavioral, data, permission, or upgrade impact. The strings are translatable and will be picked up by the standard translation extraction.

Adds AboutTitle and AboutText properties to page 9852 (Effective Permissions) so the page shows a teaching tip, consistent with sibling permission pages.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: d77332c6-59ac-4ca4-b8f3-342b6baa5d33
@onbuyuka
Onat Buyukakkus (onbuyuka) requested a review from a team August 24, 2026 22:53
@onbuyuka
Onat Buyukakkus (onbuyuka) requested a review from a team as a code owner August 24, 2026 22:53
@github-actions github-actions Bot added the Team: Integrations GitHub request for Integrations area label Aug 24, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone Aug 24, 2026
@alexei-dobriansky

Copy link
Copy Markdown
Contributor

AI PR Review - Round 1

Recommendation: Accept

Risk assessment: The page metadata addition is self-contained and does not change permission calculations or page behavior.

Findings / suggestions

None.


Review mode: autonomous conversation comment (interactive:false). A human should make the final approve/request-changes decision.

[AI-PR-REVIEW] by=alexei-dobriansky round=1 sha=85071be63bb78d71df4540ee9028687489367e4b promptVersion=good-sense-reviewer-2026-08 reviewKey=cmanual10579 suggestions=[]

@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Good Sense Reviewer - Round 2

Recommendation: Accept

What this PR does

This change adds AboutTitle and AboutText to page 9852, "Effective Permissions", so the page can show a teaching tip. The changed file only adds static page metadata before the existing page behavior settings. This matches the pattern used by nearby permission pages and does not change page triggers, permissions, data reads, or edit behavior.

Problem-solution fit

Fit: Strong

The bug says this page is missing a teaching tip, and the diff adds the requested page-level teaching-tip metadata. The scope is narrow and does not add unrelated changes.

New observations (full diff fallback)

None. The full diff is a metadata-only addition, and I did not find a correctness, compatibility, data, or test concern that needs a suggestion.

Risk assessment and necessity

Risk: Very low. The change only adds static teaching-tip text to EffectivePermissions.Page.al; it does not change data access, permission calculations, page actions, or public APIs.

Necessity: The change is needed to give this administration page the same in-product help pattern as related permission pages. Tests are not needed because there is no executable logic to exercise.


[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=10579 round=2 by=alexei-dobriansky at=2026-08-27T22:30:37.729Z lastSha=85071be63bb78d71df4540ee9028687489367e4b reviewKey=d6988498b740ed79c669fa02d0c94e7f080de1711ac095eabbd3e8be39b120c6 suggestions=none parentRound=1

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Stale Status Check Deleted

The Pull Request Build workflow run for this PR was older than 72 hours and has been deleted.

📋 Why was it deleted?

Status checks that are too old may no longer reflect the current state of the target branch. To ensure this PR is validated against the latest code and passes up-to-date checks, a fresh build is required.


🔄 How to trigger a new status check:

  1. 📤 Push a new commit to the PR branch, or
  2. 🔁 Close and reopen the PR

This will automatically trigger a new Pull Request Build workflow run.

auto-merge was automatically disabled August 28, 2026 07:26

Pull request was closed

@onbuyuka
Onat Buyukakkus (onbuyuka) added this pull request to the merge queue Aug 28, 2026
Merged via the queue into main with commit b89ada6 Aug 28, 2026
344 of 346 checks passed
@onbuyuka
Onat Buyukakkus (onbuyuka) deleted the bugs/638696-effective-permissions-teaching-tip branch August 28, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team: Integrations GitHub request for Integrations area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants