Skip to content

[29.0] bug 643971 - Enhance vendor and customer checks in advance letters and update blocked status validation #10950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
David Holuša (DavidHolusa) merged 2 commits into from
Sep 4, 2026
Merged

[29.0] bug 643971 - Enhance vendor and customer checks in advance letters and update blocked status validation #10950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4423e73
Enhance vendor and customer checks in advance letters and update bloc…
DavidHolusa Sep 2, 2026
0f356e6
fix tests
DavidHolusa Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Apps/CZ/AdvancePaymentsLocalization/app/Src/Reports/CreatePurchAdvLetterCZZ.Report.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ namespace Microsoft.Finance.AdvancePayments;
using Microsoft.Finance.Currency;
using Microsoft.Purchases.Document;
using Microsoft.Purchases.Posting;
using Microsoft.Purchases.Vendor;
using System.Utilities;

report 31029 "Create Purch. Adv. Letter CZZ"
Expand Down Expand Up @@ -243,8 +244,13 @@ report 31029 "Create Purch. Adv. Letter CZZ"
end;

procedure SetPurchHeader(var NewPurchaseHeader: Record "Purchase Header")
var
Vendor: Record Vendor;
begin
NewPurchaseHeader.TestField("Document Type", NewPurchaseHeader."Document Type"::Order);
Vendor.Get(NewPurchaseHeader."Pay-to Vendor No.");
Vendor.CheckBlockedVendOnAdvanceLettersCZZ(false);

PurchaseHeader := NewPurchaseHeader;
PurchPost.GetPurchLines(PurchaseHeader, TempPurchaseLine, 0);
TempPurchaseLine.CalcSums("Amount Including VAT");
Expand Down
6 changes: 6 additions & 0 deletions src/Apps/CZ/AdvancePaymentsLocalization/app/Src/Reports/CreateSalesAdvLetterCZZ.Report.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ namespace Microsoft.Finance.AdvancePayments;
using Microsoft.Finance.Currency;
using Microsoft.Projects.Project.Job;
using Microsoft.Projects.Project.Planning;
using Microsoft.Sales.Customer;
using Microsoft.Sales.Document;
using Microsoft.Sales.Posting;
using System.Utilities;
Expand Down Expand Up @@ -405,8 +406,13 @@ report 31012 "Create Sales Adv. Letter CZZ"
end;

procedure SetSalesHeader(var NewSalesHeader: Record "Sales Header")
var
Customer: Record Customer;
begin
NewSalesHeader.TestField("Document Type", NewSalesHeader."Document Type"::Order);
Customer.Get(NewSalesHeader."Bill-to Customer No.");
Customer.CheckBlockedCustOnAdvanceLettersCZZ(false);

SourceSalesHeader := NewSalesHeader;
SalesPost.GetSalesLines(SourceSalesHeader, TempSalesLine, 0);
TempSalesLine.CalcSums("Amount Including VAT");
Expand Down
2 changes: 1 addition & 1 deletion src/Apps/CZ/AdvancePaymentsLocalization/app/Src/TableExtensions/CustomerCZZ.TableExt.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ tableextension 31045 "Customer CZZ" extends Customer
if "Privacy Blocked" then
CustPrivacyBlockedErrorMessage(Rec, Transaction);

if Blocked <> Blocked::" " then
if Blocked in [Blocked::All, Blocked::Invoice] then
CustBlockedErrorMessage(Rec, Transaction);
end;
}
18 changes: 14 additions & 4 deletions src/Apps/CZ/AdvancePaymentsLocalization/test/Src/SalesAdvancePaymentsCZZ.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2835,9 +2835,14 @@ codeunit 148109 "Sales Advance Payments CZZ"
CreateBlockedCustomer(Customer, CustomerBlocked, PrivacyBlocked);

// [WHEN] Create sales advance letter with blocked customer
asserterror LibrarySalesAdvancesCZZ.CreateSalesAdvLetterHeader(SalesAdvLetterHeaderCZZ, AdvanceLetterTemplateCZZ.Code, Customer."No.", '');
if (CustomerBlocked = CustomerBlocked::Ship) and not PrivacyBlocked then
LibrarySalesAdvancesCZZ.CreateSalesAdvLetterHeader(SalesAdvLetterHeaderCZZ, AdvanceLetterTemplateCZZ.Code, Customer."No.", '')
else
asserterror LibrarySalesAdvancesCZZ.CreateSalesAdvLetterHeader(SalesAdvLetterHeaderCZZ, AdvanceLetterTemplateCZZ.Code, Customer."No.", '');

// [THEN] Error will occur
// [THEN] Error will occur when customer is blocked except when shipping is allowed
if (CustomerBlocked = CustomerBlocked::Ship) and not PrivacyBlocked then
exit;
if PrivacyBlocked then
Assert.ExpectedError(StrSubstNo(PrivacyBlockedCustomerErr, 'create', Customer."No."))
else
Expand Down Expand Up @@ -2875,9 +2880,14 @@ codeunit 148109 "Sales Advance Payments CZZ"
Customer.Modify(true);

// [WHEN] Post sales advance payment
asserterror LibrarySalesAdvancesCZZ.PostSalesAdvancePayment(GenJournalLine);
if (CustomerBlocked = CustomerBlocked::Ship) and not PrivacyBlocked then
LibrarySalesAdvancesCZZ.PostSalesAdvancePayment(GenJournalLine)
else
asserterror LibrarySalesAdvancesCZZ.PostSalesAdvancePayment(GenJournalLine);

// [THEN] Error will occur
// [THEN] Error will occur when customer is blocked except when shipping is allowed
if (CustomerBlocked = CustomerBlocked::Ship) and not PrivacyBlocked then
exit;
if PrivacyBlocked then
Assert.ExpectedError(StrSubstNo(PrivacyBlockedCustomerErr, 'post', Customer."No."))
else
Expand Down
Loading