Skip to content

Natvis: resolve typedef and base-class type names when rule lookup misses #1606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lugerard wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Natvis: resolve typedef and base-class type names when rule lookup misses #1606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d92b25
Natvis: resolve typedef and base-class names when rule lookup misses
lugerard Jul 6, 2026
38ded54
Recognize base-class children that lldb reports with a value
lugerard Jul 6, 2026
d00b0ee
Natvis: add end-to-end test for typedef and base-class resolution
lugerard Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/MIDebugEngine/Engine.Impl/Variables.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,10 +297,17 @@ private VariableInformation(TupleValue results, VariableInformation parent, stri

int index;

if (!results.Contains("value") && (Name == TypeName || (Name.Contains("::") && name == null)))
if ((!results.Contains("value") && (Name == TypeName || (Name.Contains("::") && name == null)))
|| (Name == TypeName && Name.IndexOfAny(s_typeNameOnlyChars) >= 0))
{
// base classes show up with no value and exp==type
// base classes show up with no value and exp==type
// (sometimes underlying debugger does not follow this convention, when using typedefs in templated types so look for "::" in the field name too)
// lldb reports base-class children WITH an aggregate value ("{...}"), so
// additionally treat exp==type as a base class whenever the name cannot
// be a field identifier (template arguments, scope operator, space).
// Known gap: a base whose name is a plain identifier, reported with a
// value, stays classified as a field — accepting it would risk
// misclassifying a member named after its type.
Name = TypeName + " (base)";
Value = TypeName;
VariableNodeType = NodeType.BaseClass;
Expand Down Expand Up @@ -392,6 +399,10 @@ public enum NodeType

public NodeType VariableNodeType { get; private set; }

// Characters that can appear in a type name but never in a field identifier —
// used to recognize base-class children whose expression equals their type name.
private static readonly char[] s_typeNameOnlyChars = new char[] { '<', ':', ' ' };

private static readonly string[] s_stringTypes = new string[] {
@"^char *\*$",
@"^char *\[[0-9]*\]$",
Expand Down
Loading