Skip to content

fix(loader): close model task JSON file and read it as UTF-8 #1422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
genisis0x wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(loader): close model task JSON file and read it as UTF-8 #1422

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion rdagent/components/loader/task_loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ def __init__(self, json_uri: str) -> None:

def load(self, *argT, **kwargs) -> Sequence[ModelTask]:
# json is supposed to be in the format of {model_name: dict{model_data}}
model_dict = json.load(open(self.json_uri, "r"))
with open(self.json_uri, "r", encoding="utf-8") as f:
model_dict = json.load(f)
# FIXME: the model in the json file is not right due to extraction error
# We should fix them case by case in the future
#
Expand Down
Loading