Skip to content

Fix remaining outerloop test failures #20457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ankit Jain (radical) merged 2 commits into from
Oct 1, 2026
Merged

Fix remaining outerloop test failures #20457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b58222d
test(cli): provision Java for outerloop tests
radical Sep 30, 2026
dc6669c
test(dashboard): fix terminal outerloop interactions
radical Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tests/Aspire.Cli.Tests/Aspire.Cli.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@
<RunOnAzdoHelixWindows>false</RunOnAzdoHelixWindows>
<RunOnAzdoHelixLinux>false</RunOnAzdoHelixLinux>
<RunOnGithubActionsMacOS>true</RunOnGithubActionsMacOS>
<!-- The outerloop-only Maven reactor tests execute fixtures compiled for Java 21. Regular CLI test
runs exclude those tests, so avoid provisioning a JDK for every CLI job. -->
<RequiresJava Condition="'$(RunOuterloopTests)' == 'true'">true</RequiresJava>
Comment thread
radical marked this conversation as resolved.
Resolved
</PropertyGroup>

<ItemGroup>
Expand Down
6 changes: 5 additions & 1 deletion tests/Aspire.Dashboard.Tests/Integration/Playwright/Infrastructure/MockDashboardClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,11 @@ public MockDashboardClient(IReadOnlyList<ResourceViewModel>? resources = null)
public Task<ResourceCommandResponseViewModel> ExecuteResourceCommandAsync(string resourceName, string resourceType, CommandViewModel command, ExecuteResourceCommandOptions options, CancellationToken cancellationToken) => throw new NotImplementedException();
public Task<string> UploadFileAsync(Stream fileStream, string fileName, long expectedSize, int interactionId, string inputName, CancellationToken cancellationToken) => throw new NotImplementedException();
public Task<Stream> AttachTerminalAsync(string terminalId, CancellationToken cancellationToken) => throw new NotImplementedException();
public IAsyncEnumerable<WatchTerminalsUpdate> SubscribeTerminalsAsync(CancellationToken cancellationToken) => throw new NotImplementedException();
public async IAsyncEnumerable<WatchTerminalsUpdate> SubscribeTerminalsAsync([EnumeratorCancellation] CancellationToken cancellationToken)
{
await Task.CompletedTask;
yield break;
}
public Task CloseTerminalAsync(string terminalId, CancellationToken cancellationToken) => throw new NotImplementedException();
public async IAsyncEnumerable<IReadOnlyList<ResourceLogLine>> SubscribeConsoleLogs(string resourceName, [EnumeratorCancellation] CancellationToken cancellationToken)
{
Expand Down
9 changes: 6 additions & 3 deletions tests/Aspire.Dashboard.Tests/Integration/Playwright/TerminalDockTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,13 @@ public async Task EmptyDock_ResizingPreservesContentInPriorityOrder()
{
await RunTestAsync(async page =>
{
await fixture.StartSessionAsync();
var (updates, _) = await fixture.StartSessionAsync();
await page.SetViewportSizeAsync(1280, 900);
await page.GotoAsync("/").DefaultTimeout();
await page.GetByRole(AriaRole.Button, new() { Name = "Toggle terminal (`)", Exact = true }).ClickAsync();
await updates.Writer.WriteAsync(new WatchTerminalsUpdate
{
Snapshot = new TerminalDescriptorList { ActivatedTerminalId = "missing" }
});
var panel = page.Locator(".terminal-dock-panel");
var heading = panel.GetByRole(AriaRole.Heading, new() { Name = "No docked terminals", Exact = true });
var hint = panel.Locator(".terminal-dock-panel-hint");
Expand Down Expand Up @@ -321,7 +324,7 @@ await RunTestAsync(async page =>
if (hideDock)
{
await page.Locator(".terminal-dock-collapse").ClickAsync();
focusTarget = page.GetByRole(AriaRole.Button, new() { Name = "Toggle terminal (`)", Exact = true });
focusTarget = page.Locator("#dashboard-settings-button");
}
else
{
Expand Down
Loading