fix(slides): improve accessibility and authoring guidance - #2906
Open
Allen Greaves (agreaves-ms) wants to merge 2 commits into
Open
Allen Greaves (agreaves-ms) wants to merge 2 commits into
Allen Greaves (agreaves-ms) wants to merge 2 commits into
Conversation
- Add reading view, touch scrolling and keyboard focus support - Improve announcements, headings and diagram alternatives - Update the starter and add gallery and deck browser regressions ♿ - Generated by Copilot
♿ - Generated by Copilot
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2906 +/- ##
=======================================
Coverage 83.01% 83.01%
=======================================
Files 186 186
Lines 34939 34939
Branches 231 231
=======================================
Hits 29004 29004
Misses 5861 5861
Partials 74 74
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
Eval Execution✅ Status: Passed
No changed AI artifacts required evaluation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Make the HVE Updates presentation readable and operable across desktop, narrow-screen and keyboard use, and carry the accessibility requirements into the HVE Slides starter and authoring guidance.
Related Issue(s)
None identified in the branch or commit history.
Type of Change
Select all that apply:
Code & Documentation:
Infrastructure & Configuration:
AI Artifacts:
hve-builderand addressed all actionable findings.github/instructions/*.instructions.md).github/prompts/*.prompt.md).github/agents/*.agent.md).github/skills/*/SKILL.md).github/hooks/*/*.json)evals/)Other:
.ps1,.sh,.py)Sample Prompts (for AI Artifact Contributions)
User Request:
/hve-slides deck=slides/hve-updates mode=updateMake the deck readable on phones and usable with a keyboard, then verify the generated HTML.Execution Flow:
Inspect the existing slide source and starter, apply scoped accessibility criteria, rebuild the bundle and gather separate scanner, keyboard, accessibility-tree and rendering evidence. Reuse current dependencies and report unavailable checks without installing prerequisites implicitly.
Output Artifacts:
Updated deck source and
docs/slides/hve-updates.html, with a Reading view toggle, diagram descriptions and keyboard-accessible dialogs. The starter and references retain these behaviors for future decks.Success Indicators:
At 320 CSS pixels, slide content and walkthrough actions remain reachable without horizontal overflow. Keyboard navigation and dialog scrolling pass the focused Playwright spec; static scans are not substituted for interaction evidence.
For detailed contribution requirements, see:
Testing
Passed targeted preflight:
git diff --check origin/main...HEADnpm run slides:check: committed HTML matches source.npm run test:slides: 16 passed.npm test --prefix slides/hve-updates: 21 passed.npm test --prefix .github/skills/hve-slides/templates/deck: 11 passed.docs/docusaurus:npm exec -- jest --runInBand --runTestsByPath src/pages/__tests__/slides.test.tsx: 10 passed.docs/docusaurus:npm exec -- playwright test --config ../../logs/slides-playwright.config.ts e2e/slides.spec.ts --workers=1 --reporter=list: 5 passed. The ignored local configuration uses already-installed Chromium; CI retains the repository's system-Chrome configuration.npm run docs:lint,npm run docs:lint:labels,npm run docs:typecheckand focused ESLint for the new spec.npm run validate:skills -- -ChangedFilesOnlyandnpm run lint:frontmatter -- -ChangedFilesOnly.npm run validate:copyright -- -Path docs/docusaurus/e2e -FailOnMissing: 31 files passed after the two-line header repair.npm run lint:tables, changed-file CSpell, and direct Markdownlint API checks using repository rules for all six changed Markdown files.npm run plugin:validateandnpm run docs:generate:check: projections already synchronized; zero generated reference changes.Implementation validation also included a production site build, integrated-browser investigation, axe scans across the 26-slide deck and four-slide starter, dialog checks, all 52 slide/step states at 320px with increased text spacing, 200% text sizing, and isolated offline execution of a renamed HTML bundle without remote runtime requests.
Checklist
Required Checks
AI Artifact Contributions
hve-builderreview mode to review contributionhve-builderreviewRequired Local Checks
The following local-safe validation commands must pass before merging:
npm run validate:localnpm run validate:docsnpm run spell-checknpm run lint:md-linksSecurity Considerations
No dependencies, credentials, workflow permissions or external services are added. Presenter notes remain part of the intentionally shareable HTML.
Additional Notes
getting-started/methods/comparisonlinking to the missinginstall#marketplace-installanchor.