Skip to content

ignore process permission denied #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Peter Pickford (ppickfor) wants to merge 1 commit into
base: main
Choose a base branch
from
+21 −11
Open

ignore process permission denied #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 21 additions & 11 deletions src/process.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ fn kill_process_if(
process: &RunningProcess,
path: &Path,
) -> Result<(), Box<dyn error::Error>> {
use windows_sys::Win32::Foundation::{CloseHandle, MAX_PATH};
use windows_sys::Win32::Foundation::{CloseHandle, MAX_PATH, ERROR_ACCESS_DENIED, GetLastError};
use windows_sys::Win32::System::ProcessStatus::K32GetModuleFileNameExW;
use windows_sys::Win32::System::Threading::{
OpenProcess, TerminateProcess, PROCESS_QUERY_INFORMATION, PROCESS_TERMINATE,
Expand All @@ -104,16 +104,26 @@ fn kill_process_if(
process.id,
);

if ptr::eq(handle as *mut c_void, ptr::null()) {
return Err(io::Error::new(
io::ErrorKind::Other,
format!(
"Failed to open process: {}",
util::get_last_error_message()?
),
)
.into());
}
if ptr::eq(handle as *mut c_void, ptr::null_mut()) {
let error_code = GetLastError();

// Check for insufficient permission
if error_code == ERROR_ACCESS_DENIED {
info!(
log,
"Insufficient permissions to open process: {}", process.id
);
return Ok(()); // Ignore the error and return Ok
} else {
return Err(io::Error::new(
io::ErrorKind::Other,
format!(
"Failed to open process: {}",
util::get_last_error_message()?
),
).into());
}
}

let mut raw_path = [0u16; MAX_PATH as usize];
let len = K32GetModuleFileNameExW(handle, mem::zeroed(), raw_path.as_mut_ptr(), MAX_PATH)
Expand Down