Skip to content

Fix resource disk detection for NVMe-only VM sizes #4461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
umfranci wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix resource disk detection for NVMe-only VM sizes #4461

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28fb0bf
changes to recognize nvme disks
umfranci Apr 12, 2026
37857f8
adding self tests for resource disks
umfranci May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lisa/sut_orchestrator/azure/platform_.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2263,7 +2263,10 @@ def _resource_sku_to_capability( # noqa: C901
# some vm size do not have resource disk present
# https://docs.microsoft.com/en-us/azure/virtual-machines/azure-vms-no-temp-disk
resource_disk_size = azure_raw_capabilities.get("MaxResourceVolumeMB", None)
if resource_disk_size and int(resource_disk_size) > 0:
nvme_disk_size = azure_raw_capabilities.get("NvmeDiskSizeInMiB", None)
if (resource_disk_size and int(resource_disk_size) > 0) or (
nvme_disk_size and int(nvme_disk_size) > 0
):
Comment thread
umfranci marked this conversation as resolved.
node_space.disk.has_resource_disk = True
else:
node_space.disk.has_resource_disk = False
Expand Down
Loading