Fix Cloud Hypervisor live migration nextest filtering#4563
Open
vyadavmsft wants to merge 4 commits into
Open
Conversation
🤖 AI Test SelectionNo test cases were selected for this PR. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Cloud Hypervisor test harness to run live migration tests through the CLI path and to build a shell-safe nextest filter expression while preserving the base filter behavior.
Changes:
- Route live migration execution through the integration CLI test type and apply a nextest
--filterset-based filter. - Add helper logic to construct a combined nextest filterset (base substring + include + exclude).
- Adjust subtest listing and run orchestration to support
cli_test_type/cli_test_filteroverrides.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lisa/microsoft/testsuites/cloud_hypervisor/ch_tests.py | Switch live migration run to the CLI integration path and pass only/skip plus CLI filtering parameters. |
| lisa/microsoft/testsuites/cloud_hypervisor/ch_tests_tool.py | Add nextest filterset construction and CLI-path execution for filtered runs, plus supporting subtest prep parameters. |
Run Cloud Hypervisor live migration tests through the CLI path and construct the nextest filter as a shell-safe expression. Preserve the base test filter while excluding the serial-only live migration test from the parallel run.
🤖 AI Test SelectionNo test cases were selected for this PR. |
LiliDeng
previously approved these changes
Jun 29, 2026
anirudhrb
requested changes
Jun 29, 2026
Replace the custom bash argument quoting helper with shlex.quote and quote the generated bash script as a whole before passing it to bash -lc. Remove the redundant cli_test_type override by running live migration through the integration test type and selecting live migration cases with the nextest filter.
🤖 AI Test SelectionNo test cases were selected for this PR. |
Derive the expected subtest set when running Cloud Hypervisor tests with a nextest CLI filter instead of passing an empty set into result processing. Fail fast if the filter and include/exclude lists select no subtests so a zero-test run cannot pass silently.
🤖 AI Test SelectionNo test cases were selected for this PR. |
anirudhrb
requested changes
Jul 1, 2026
| ref: str = "", | ||
| only: Optional[List[str]] = None, | ||
| skip: Optional[List[str]] = None, | ||
| only_test_prefixes: Optional[List[str]] = None, |
Collaborator
There was a problem hiding this comment.
Is this unused? I don't see any caller passing this.
Collaborator
Author
There was a problem hiding this comment.
Good catch. This was leftover from an earlier live-migration filtering approach. The current [cli_test_filter] path now derives the filtered subtest set directly, and no caller passes only_test_prefixes, so I removed it.
Drop the only_test_prefixes parameter from the Cloud Hypervisor test runner because no caller supplies it. Remove the corresponding private prefix-filter branches so the run_tests signature only exposes supported include, exclude, and CLI substring filters.
🤖 AI Test SelectionNo test cases were selected for this PR. |
Comment on lines
+501
to
+505
| test_script_args = f"--test-filter {shlex.quote(nextest_filter)}" | ||
| cmd_args = ( | ||
| f"tests --hypervisor {hypervisor} --{test_type} -- " | ||
| f"{test_script_args}" | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run Cloud Hypervisor live migration tests through the CLI path and construct the nextest filter as a shell-safe expression. Preserve the base test filter while excluding the serial-only live migration test from the parallel run.
Description
Related Issue
Type of Change
Checklist
Test Validation
Key Test Cases:
Impacted LISA Features:
Tested Azure Marketplace Images:
Test Results