MCP Tools in Drills: Drill Validate for Execution - #3355
Open
dynamicdhx wants to merge 2 commits into
Open
Conversation
dynamicdhx
requested review from
a team and
Vinay Gera (g2vinay)
as code owners
August 24, 2026 11:26
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
Author
Tool Description Evaluator ResultsTest 1Expected Tool: Results
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Resilience Management drill operation to the Azure MCP toolset: validating a drill for execution from specified source locations. This expands the existing resilience drill command group with a new tool/command and wires it through service implementation, registration, tests, and documentation surfaces.
Changes:
- Introduces
DrillValidateForExecutionCommandwith options/model types and JSON source-generation registration. - Implements
ValidateDrillForExecutionAsyncin the Resilience Management service layer and exposes it viaIResilienceManagementService. - Adds unit + command tests and updates Azure MCP documentation, consolidated tool mappings, and a changelog entry.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.ResilienceManagement/tests/Azure.Mcp.Tools.ResilienceManagement.Tests/ResilienceManagementCommandTests.cs | Adds an end-to-end style test invoking the new drill validate-for-execution tool. |
| tools/Azure.Mcp.Tools.ResilienceManagement/tests/Azure.Mcp.Tools.ResilienceManagement.Tests/Drills/DrillValidateForExecutionCommandTests.cs | Adds unit tests covering validation, success path, and error handling for the new command. |
| tools/Azure.Mcp.Tools.ResilienceManagement/tests/Azure.Mcp.Tools.ResilienceManagement.Tests/assets.json | Updates recorded test asset tag to include the new behavior. |
| tools/Azure.Mcp.Tools.ResilienceManagement/src/Services/ResilienceManagementService.cs | Implements drill validate-for-execution service operation using the ARM SDK. |
| tools/Azure.Mcp.Tools.ResilienceManagement/src/Services/IResilienceManagementService.cs | Adds the new service method contract. |
| tools/Azure.Mcp.Tools.ResilienceManagement/src/ResilienceManagementSetup.cs | Registers the new command in DI and adds it to the drill command group. |
| tools/Azure.Mcp.Tools.ResilienceManagement/src/Options/Drills/DrillValidateForExecutionOptions.cs | Defines CLI/tool options for validate-for-execution. |
| tools/Azure.Mcp.Tools.ResilienceManagement/src/Models/DrillValidateForExecutionResult.cs | Adds a result model for returning operation ID and completion state. |
| tools/Azure.Mcp.Tools.ResilienceManagement/src/Commands/ResilienceManagementJsonContext.cs | Registers new result types for AOT-safe source-generated JSON serialization. |
| tools/Azure.Mcp.Tools.ResilienceManagement/src/Commands/Drills/DrillValidateForExecutionCommand.cs | Implements the new command, option validation, execution flow, and error mapping. |
| servers/Azure.Mcp.Server/src/Resources/consolidated-tools.json | Maps the new tool under the resilience management “create” consolidated tool and updates its metadata/description. |
| servers/Azure.Mcp.Server/docs/e2eTestPrompts.md | Adds an e2e prompt for the new tool name. |
| servers/Azure.Mcp.Server/docs/azmcp-commands.md | Adds the command reference entry for azmcp resilience drill validate-for-execution. |
| servers/Azure.Mcp.Server/changelog-entries/dhruvbharuka-drill-validate-for-execution.yml | Adds a changelog entry for the new tool. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+47
to
+56
| "name": "create_azure_resilience_management_resources", | ||
| "description": "Create, update, or delete Azure Resilience Management resources, including usage plans, usage plan enrollments, and recovery plans for Azure service groups.", | ||
| "description": "Create, update, delete, or validate Azure Resilience Management resources, including usage plans, usage plan enrollments, recovery plans, and drills for Azure service groups.", | ||
| "toolMetadata": { | ||
| "destructive": { | ||
| "value": true, | ||
| "description": "This tool may delete or modify existing resources in its environment." | ||
| }, | ||
| "idempotent": { | ||
| "value": true, | ||
| "description": "Running this operation multiple times with the same arguments produces the same result without additional effects." | ||
| "value": false, | ||
| "description": "This tool includes operations that may produce additional effects when run multiple times with the same arguments." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
[Provide a clear, concise description of the changes][Add additional context, screenshots, or information that helps reviewers]GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationREADME.mdchanges running the script./eng/scripts/Process-PackageReadMe.ps1. See Package READMEToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabelservers/Azure.Mcp.Server/docs/azmcp-commands.md./eng/scripts/Update-AzCommandsMetadata.ps1to update tool metadata inazmcp-commands.md(required for CI)servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline