nvx-rs slimming 4.2.3: the old configs, the old launch code and bundled are gone #1122

Parent: #1087, in #1076. Needs: #1121. Unblocks: #1123, #1124, #1125. No PR of this group merges before the API-ready commit.

Leaving code only. Every PR in this group changes only code that this workstream removes from NVX: the old config types, the old launch code, its one-shot launch and checked-file transfer, and the bundled feature, with the edits that remove references to it. Nothing that stays changes, and no later PR uses what these PRs change, so the size limits for kept code don't apply. Each PR still records its core lines and counted files, and its description opens with this note.

Goal. The old config types and the rest of host::launch, the old aggregate naming and boot rendering, NVX's old guest tokens, the one-shot foreground launch, the checked-file transfer and spawn_command are gone, with the crate-private code that those deletions leave unused. The shell /init stops reading OpenVMM's lifecycle tokens. The private OS layer keeps only the launch code that host::vm::spawn uses. bundled, its build script and its variables go; NVX_OPENVMM, NVX_AUTO_DOWNLOAD and NVX_RS keep their meaning.

Notes.

• Both PRs take more than 5 counted files. Deleting the old configs and launch code touches 9 files, and removing bundled 10, all of which only lose code.
• Mixed mount modules stay until their last user. SL6.3 removes only the rendering functions; plan_mounts, plan_mounts_with and path_text stay for nvx-rs slimming 4.3.1: image staging, artifact discovery, the policy-file reader and the mount syntax are private to the CLI #1124.
• The fake OpenVMM already owns its emulated tokens. nvx-rs slimming 3.1.4: run uses the new interface and the CLI's own guest tokens #1109 removed its use of the old token constant before SL6.3 deletes it.

PRs, in order. Each PR has one goal, leaves dev green, and names in its description each old test of its area as kept, rewritten or retired, with each change that check_test_changes.py reports. Its tests follow the repository's test layout: a module's unit tests, and the code that only they use, sit in its tests.rs or tests/ and move with it. The estimates count core lines (code, not comments, docs or tests) and counted files; each PR records its measured values. Each PR does what its Scope says and no more: a case, input or layout that its Scope doesn't name, and whatever "Not in this PR" lists, is out of scope. Address every review comment within the scope, and ask before acting on one that asks for more.

1. SL6.3: The old config types are gone.

   • Objective: The old configuration, launch model, one-shot foreground launcher and checked-file transfer are no longer used. They, the generic spawn helper, aggregate rendering and guest tokens are deleted, while VM spawning keeps its private synchronization and failed-spawn cleanup.
   • Contents: Leaving code. Delete LaunchSpec, SandboxPlan, SandboxLaunch, SandboxSettings, SandboxNetwork and CaptureClass, the parts of host::sandbox that only they use, prepared included, the old aggregate naming and boot rendering (aggregate_child_name, aggregate_child_argument, mount_argument, BootShares, boot_shares, aggregate_share_tokens, aggregate_command_line_fragment and export_command_line_fragment; plan_mounts, plan_mounts_with and the shared path_text stay for SL6.7b), and NVX's guest tokens, which the CLI now renders, with WORKLOAD_ACCOUNT_TOKEN and the workload limits. The rest of host::launch goes too: WorkloadIdentity (DEFAULT, select), MAX_TIMEOUT, DEFAULT_MEMORY_MIB, DEFAULT_HOSTNAME, base_command_line, kernel_parameters_problem, timeout_problem and LaunchSpec::check_process_command_line; DEFAULT_GUEST_NETWORK, COMMAND_LINE_BUDGET and the Windows command-line helpers already live in host::config. What dev added on the old path goes too: VmmLaunch (with RESERVE and arguments) and LaunchSpec::vmm_launch, OPENVMM_COMMAND_LINE_RESERVE, SandboxPlan::check_adapter_launch and PreparedLaunch::adapter_arguments; VmConfig::check_command_line keeps their guarantee. Delete the old one-shot foreground launch in platform's Linux and Windows paths and host::sys::process, Windows LaunchedProcess::{wait_timeout, request_termination}, the checked-file handoff (Inherited::proc_path, ProcessHandle::close_inherited), the generic spawn_command, and the crate-private code that these deletions leave unused; the internal spawn lock and termination after a failed spawn stay. The shell /init stops reading OpenVMM's lifecycle tokens, and so stops handing a layered root that has one to nvx-init-agent.
   • Scope:
     • Delete the old config types and their host::sandbox code, including prepared; delete old aggregate and boot rendering, but keep plan_mounts, plan_mounts_with and shared path_text for nvx-rs slimming 4.3.1: image staging, artifact discovery, the policy-file reader and the mount syntax are private to the CLI #1124.
     • Delete the remaining old host::launch values and checks, VmmLaunch, its reserve and arguments, and the adapter launch checks; keep command-line helpers in host::config and VmConfig::check_command_line.
     • Delete NVX's guest tokens, WORKLOAD_ACCOUNT_TOKEN and workload limits, and stop the old launch paths and shell /init from reading or passing the obsolete lifecycle and workload tokens.
     • Delete the Linux and Windows one-shot foreground launch paths, their host::sys::process code, and Windows LaunchedProcess::{wait_timeout, request_termination}.
     • Delete Inherited::proc_path, ProcessHandle::close_inherited, spawn_command, and crate-private code left unused; keep the internal spawn lock and termination after a failed spawn.
     • Retire the deleted paths' tests and remove the production seam entry for sandbox/plan.rs; retained mount syntax, image staging, path rules, spawn-lock and failed-spawn tests stay.
   • Not in this PR:
     • Rewriting, refactoring or improving retained mount planning, path handling, VM configuration or VM spawning.
     • Re-homing deleted config, renderer, token, one-shot launch or checked-file APIs, or adding replacements.
     • Deleting plan_mounts, plan_mounts_with or path_text; nvx-rs slimming 4.3.1: image staging, artifact discovery, the policy-file reader and the mount syntax are private to the CLI #1124 still needs them.
     • Changing DEFAULT_GUEST_NETWORK, COMMAND_LINE_BUDGET, retained Windows command-line helpers, the private spawn lock or failed-spawn termination.
     • Incrementing a contract version; this workstream keeps the existing version.
   • Approach: Delete the named config, rendering, foreground-launch, checked-file and generic-spawn items, remove their references, and retire their tests. Follow the compiler to delete crate-private code that becomes unused. Edit the shell init only to remove the three obsolete tokens and route. Keep retained mount, command-line, VM-spawn, spawn-lock and failed-spawn code at their current owners.
   • Done when:
     • The Test changes report lists the deleted config, launch, aggregate-rendering, checked-file, foreground-launch and generic-spawn cases as removed, and the description retires each one.
     • The old launch paths pass neither --microvm-lifecycle nor --microvm-workload-identity, and the shell /init no longer recognizes their three tokens.
     • The internal spawn-lock and failed-spawn termination tests still pass.
     • Mount syntax, image-staging and path-rule tests remain.
   • Needs: SL6.1, in nvx-rs slimming 4.2.2: the old clone path, template store and sandbox store are gone #1121.
   • Estimate: 0 core lines (deletions), 9 counted files.

2. SL6.6a: The bundled feature is gone.

   • Objective: The bundled feature and its release-staging contract have no remaining user. The feature, build script, artifact manifest and private bundle variables are deleted from code and tooling without changing the retained discovery and download contracts.
   • Contents: Leaving code. CI's check action and mutants workflow, crate_release.py, the guest build's inventory (build_constants.py) and the provenance inventory of nvx.py's nvx-rs (nvx_rs.py's source_files(), which requires each file that it lists) stop building, checking or listing bundled and its build script. Delete the build script, links = "nvx", artifacts.json and its release check, NVX_BUNDLE_DIR, NVX_BUNDLE_HYPERVISOR, NVX_BUNDLE=skip and DEP_NVX_ARTIFACTS_DIR, from the manifest, lib.rs, contract.rs, host::artifacts and the CLI's downloads. contract::manifest_mismatches, which dev added, with the time ABI's and the restore packets' fields, stays in contract: the CLI's discovery and downloads check manifests with it.
   • Scope:
     • Delete nvx-rs/build.rs, the bundled feature, links = "nvx", artifacts.json handling and its release check.
     • Remove NVX_BUNDLE_DIR, NVX_BUNDLE_HYPERVISOR, NVX_BUNDLE=skip and DEP_NVX_ARTIFACTS_DIR from the manifest, lib.rs, contract.rs, host::artifacts and the CLI downloads.
     • Remove bundled and its build script from the check action, mutants workflow, scripts/nvx_tools/crate_release.py, the guest build inventory in scripts/nvx_tools/build_constants.py, and the provenance inventory in scripts/nvx_tools/nvx_rs.py (source_files()), which fails on a listed file that is missing.
     • Keep NVX_OPENVMM, NVX_AUTO_DOWNLOAD, NVX_RS and contract::manifest_mismatches with its time and restore fields.
   • Not in this PR:
     • Rewriting, refactoring or improving retained artifact discovery, downloads or release tooling.
     • Moving the bundle build script or artifact manifest elsewhere.
     • Adding a replacement embedding, staging or bundle feature.
     • Changing the meaning of NVX_OPENVMM, NVX_AUTO_DOWNLOAD or NVX_RS.
     • Deleting contract::manifest_mismatches; retained discovery and downloads use it.
   • Approach: Remove the feature and every fixed reference to its build script, manifest and four private variables from the listed inventories and consumers. Keep the retained environment variables and manifest comparison code untouched; do not redesign packaging or artifact discovery.
   • Done when:
     • Release checks no longer expect artifacts.json or the deleted bundle variables.
     • CI, mutant, guest-build and provenance inventories no longer build, check or list bundled or nvx-rs/build.rs, and nvx.py still records and checks the provenance of the nvx-rs that it builds.
     • Image-staging and retained artifact tests still pass.
     • NVX_OPENVMM, NVX_AUTO_DOWNLOAD, NVX_RS and manifest_mismatches remain.
   • Needs: SL6.1, in nvx-rs slimming 4.2.2: the old clone path, template store and sandbox store are gone #1121.
   • Estimate: 50 core lines, 10 counted files.

Tests. Each PR retires the tests of what it deletes, including the old config, launch, one-shot, checked-file-transfer and bundle checks. After SL6.3, /init no longer recognizes the old lifecycle or workload tokens, and no layered root reaches the old init. Tests of the private spawn lock, failed-spawn termination, mount syntax, image staging and path rules stay. Release and guest-build inventories no longer expect bundled, its variables, artifacts.json or nvx-rs/build.rs.

Done when: every PR above has merged, with dev green.