Repository navigation
ci: install pinned NFV PR reviewer - #1249
Conversation
Install both NFV workflows with gh-aw v0.88.7, retaining default audit budgets. Runtime release and approved model are configured as repository Actions variables. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f75c2999-5f30-45c3-8a49-8709069c9d79
|
Installation verification at captured PR head
The initial filename-based disable returned 404 before registration; subsequent discovery by ID and disabling succeeded. The user explicitly chose to leave this PR draft and not merge. No activation or audit was started. Keep the reviewer disabled until an approved merge and verification against the actual default branch. A separate meaningful pilot and billable audit require separate authorization. |
There was a problem hiding this comment.
🟡 Changes recommended
Colliding artifact names prevent retention of both usage snapshots, while equal job and audit timeouts leave no margin to upload evidence after an interrupted audit.
2 open issues
What changed in this PR
Installs NFV’s prototype PR reviewer alongside NVX’s existing CI, using a pinned workflow package and gh-aw v0.88.7. Its reports describe conditional model refutations, not confirmed source bugs.
Changes:
- Adds a source-context workflow that collects immutable PR changes and validates dependency lookup hints.
- Adds sandboxed Dafny analysis, evidence retention, and PR-comment publication.
- Records package provenance and generated workflow configuration without changing existing tests or unrelated CI.
| File | Description |
|---|---|
.github/workflows/nfv-source-context.md |
Defines context collection, validation, and artifact handoff. |
.github/workflows/nfv-source-context.lock.yml |
Provides generated execution, sandboxing, and handoff jobs. |
.github/workflows/nfv-pr-review.md |
Defines the audit workflow and report publication. |
.github/aw/packages/microsoft-neuro-formal-verification-workflow-f129a0ff0f1c.json |
Records the pinned package revision and workflow hashes. |
Review effort: Balanced
| max-turns: 500 | ||
| # Independent, tool-free sessions need not reuse a cached prompt. | ||
| max-turn-cache-misses: 500 | ||
| timeout-minutes: 360 |
| continue-on-error: true | ||
| uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 | ||
| with: | ||
| name: aic-usage-cache |
WorkflowTests.test_only_the_report_job_writes_and_only_issues in scripts/test_nightly_ci.py allowed only the nightly CI report's job to write issues, so installing the NFV PR reviewer failed the NVX CLI jobs on Linux and Windows. gh-aw v0.88.7 compiles the reviewer's add-comment safe output and its default failure reporting into safe_outputs and conclusion jobs that write issues: they post the reviewer's comment on the pull request and report its failures, missing tools, and incomplete runs as issues. Compiling the reviewer without issues: write would have dropped those reports. The test now also expects the two jobs of nfv-pr-review.lock.yml, and doc/ci.md names them as the only other jobs that can write issues. Every other workflow and job still cannot. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This pull request changes existing testsIt modifies or removes 1 existing test asset(s), listed below. Review each with care: a change to a test can hide a regression that the test caught. See doc/contribute.md#changes-to-existing-tests. Test code
Relocated unchanged: 0; added: 0. Compared the merge base |

Installation
Install NFV's prototype PR reviewer using gh-aw v0.88.7.
tests-modified); no test data or test wiring changed:WorkflowTests.test_only_the_report_job_writes_and_only_issuesinscripts/test_nightly_ci.pyallowed onlynightly-ci-report.yml:reportto write issues, so this PR failed NVX CLI on Linux and Windows. gh-aw v0.88.7 compiles the reviewer'sadd-commentsafe output and default failure reporting intosafe_outputsandconclusionjobs withissues: write, which post its PR comment and report its failures, missing tools, and incomplete runs as issues. The test now also expects those two jobs ofnfv-pr-review.lock.yml, anddoc/ci.mdnames them as the only other jobs that can write issues; every other workflow and job still cannot.Both workflows compiled successfully; Markdown links and the staged diff checks passed.
Keep this PR draft until nfv-pr-review.lock.yml is confirmed disabled_manually. Keep the reviewer disabled while marking ready and merging; do not require an NFV check on this installation PR. Merge requires explicit approval. After merge, recheck actual dev package pins, variables, and secret names before enabling the reviewer. A separate meaningful implementation-change pilot and its billable audit require separate authorization.
Findings are conditional MODEL refutations, not confirmed source bugs; failure to refute is not evidence of source correctness. No audit has been started.