Fix reset button in skillmaps & hint layout, builtin extension issue - #11542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix microsoft/pxt-arcade#7625, and just in general clean up tutorial hint layout since that kept jumping off screen for me while testing the bug
https://arcade.makecode.com/app/d300780148c18b0c1054a3498f5f05d5f6482e2d-80c429f213--skillmap#beginner
also fix bug richard saw during live stream; rehydrated api info was storing incorrect value for src (so e.g. libs/corgio instead of corgio). Poked around and should be safe to fix. Additionally, found another edge case, again, while testing (using controller extension, adding a rotary encoder block, then trying to remove) -- made it check all transitive dependencies that will be removed as well
https://arcade.makecode.com/app/d300780148c18b0c1054a3498f5f05d5f6482e2d-80c429f213