Few color picker changes to propose - #11616
Joey Wunderlich (jwunderl) wants to merge 7 commits into
Conversation
|
Can we get an Arcade upload target to try out the new blocks? |
|
ah the arcade side of pr had em, here's a build with a very simple project https://arcade.makecode.com/app/590bd0d230b87b393be2ea5905452f455f73966f-ef652ebaad#pub:S43701-26279-46872-67107 |
Recompute the derived color preview before rendering so workspace loads with disabled Blockly events still reflect reconstructed literal inputs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Recompute the derived color preview before rendering so workspace loads with disabled Blockly events still reflect reconstructed literal inputs.
|
fix for decomp (it was reading values that were replaced later in decompilation pass) https://arcade.makecode.com/app/d151c4577c684b9c7a93cfb1fa84c770dc21ab6a-310979b002 |
…oft/pxt into dev/jwunderl/color-picker
|
ah i see i'm dumb, i saw a different minor issue in screenshot and misread it as that -- fix 2.0 https://arcade.makecode.com/app/384d26ca1019facdcb6c58fdd8d4071150a1654a-6d485d983c (will have to make a new block for it b/c old one got swapped in too far) |
Ah meant new blocks as in from toolbox, the old one compiled to a function it shouldn't have basically so the project javascript itself wrong now - dragging out new one, ->Javascript, >blocks works as expected as far as i can tell |
|
definitely get rid of the question mark, it looks like an error. in that case i would just kill the box entirely |





few changes to suggest:
ability to specify which format to start with via block attribute (in this case, hex b/c that's what simulator theming shows / takes in
a square at the front that evals out when possible, ? when not
ability to apply defaults to the shadow you're puttin in category, including e.g. wanted duplicateOnDrag for these blocks, color to match, etc.
do these sorts of changes make sense with what you had in mind for the builtinblockids behavior or nah / things to trim out richard?