Skip to content

Drop Microsoft.NET.Test.Sdk from the MSTest metapackage #9546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nohwnd wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −9
Draft

Drop Microsoft.NET.Test.Sdk from the MSTest metapackage #9546

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions src/Package/MSTest/MSTest.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,15 +49,14 @@
</ItemGroup>

<ItemGroup>
<!-- Microsoft.NET.Test.Sdk package is referenced by build system, so omitting it. -->
<!-- VSTest is packaging props/targets in build directory of the NuGet package instead of buildTransitive -->
<!-- To ensure that this flows to consumers of MSTest metapackage, we set PrivateAssets to none (by default, PrivateAssets includes "build") -->
<!-- If VSTest moves from build to buildTransitive, the PrivateAssets here can/should be removed. -->
<!-- Currently, VSTest isn't able to move from build to buildTransitive -->
<!-- See: https://github.com/microsoft/vstest/pull/3879, -->
<!-- https://github.com/microsoft/vstest/issues/4098 -->
<!-- https://github.com/microsoft/vstest/pull/4104 -->
<PackageReference Include="Microsoft.NET.Test.Sdk" VersionOverride="$(MicrosoftNETTestSdkVersion)" Condition="'$(TargetFramework)' != '$(UwpMinimum)'" PrivateAssets="none" />
<!--
Microsoft.NET.Test.Sdk (the classic VSTest runner, which drags in Microsoft.TestPlatform.TestHost and the
rest of the VSTest execution stack) is intentionally NOT referenced. MSTest runs as a
Microsoft.Testing.Platform (MTP) application and does not need the VSTest testhost/runner. Dropping it keeps
the MSTest package's only VSTest-lineage dependency down to Microsoft.TestPlatform.ObjectModel, which flows
transitively through Microsoft.Testing.Extensions.VSTestBridge (plus the source-only, non-flowing
Microsoft.TestPlatform.Filter.Source). MTP build integration is provided by Microsoft.Testing.Platform.MSBuild
(flowed via MSTest.TestAdapter), not by Microsoft.NET.Test.Sdk. -->
<PackageReference Include="Microsoft.Testing.Extensions.CodeCoverage" />
Comment on lines +52 to 60
</ItemGroup>

Expand Down
Loading