Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a new MessagePackFormatter.InternStrings configuration property so consumers can opt out of string interning for MessagePack user data (arguments/return values/errors), addressing the unbounded memory growth scenario described in #1434.
Changes:
- Introduces
MessagePackFormatter.InternStrings(defaulting totrue) and rebuilds user-data serialization options when toggled. - Updates
MassageUserDataOptionsto conditionally include theStringInterningResolverbased onInternStrings. - Adds unit tests that validate the default value and behavior when disabling/re-enabling interning before/after calling
SetMessagePackSerializerOptions.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/StreamJsonRpc/MessagePackFormatter.cs | Adds the InternStrings property and uses it to conditionally include string interning in the user-data resolver chain. |
| test/StreamJsonRpc.Tests/MessagePackFormatterTests.cs | Adds tests covering default and toggling behavior of InternStrings. |
This allows users to opt-out of string interning functionality. Fixes #1434
olegtk
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows users to opt-out of string interning functionality.
Closes #1434