Skip to content

Improve notifications sample with actionable and cancellable workflows - #1309

Open
Maycon Campos (mayc7n) wants to merge 1 commit into
microsoft:mainfrom
mayc7n:improve-notifications-sample
Open

Improve notifications sample with actionable and cancellable workflows#1309
Maycon Campos (mayc7n) wants to merge 1 commit into
microsoft:mainfrom
mayc7n:improve-notifications-sample

Conversation

@mayc7n

Copy link
Copy Markdown

Summary

This PR improves the notifications sample by demonstrating complete
notification workflows instead of isolated messages.
Changes

  • return notification promises from registered commands
  • demonstrate modal details and confirmation handling
  • use typed MessageItem actions
  • connect the warning's Retry action to the progress command
  • implement cooperative progress cancellation
  • clear pending timers and dispose cancellation listeners
  • report deterministic progress stages totaling 100%
  • wait for all commands in the Do Not Disturb example
  • add the Node.js types required by the sample
  • document the purpose and behavior of each notification pattern

Validation

  • npm run compile
  • npm run lint
  • git diff --check

@mayc7n

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant