[cherry-pick] sessions: Show Changes view for new sessions - #332374
Merged
Conversation
vs-code-engineering
Bot
requested a review
from Sandeep Somavarapu (sandy081)
as a code owner
August 24, 2026 16:58
vs-code-engineering
Bot
added
the
cherry-pick-artifact
Contributor
Author
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Benjamin Christopher Simmonds (@benibenj)Matched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Enables the Changes view and managed Changes tab for workspace-backed new-session drafts.
Changes:
- Removes the created-session requirement from Changes view visibility.
- Restores Changes and Files tabs while preserving Files-first draft layout.
- Updates layout tests and documentation.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/vs/sessions/SINGLE_PANE_SCENARIOS.md |
Documents draft Changes-tab behavior. |
src/vs/sessions/contrib/layout/test/browser/desktopSessionLayoutController.test.ts |
Updates managed-tab restoration expectations. |
src/vs/sessions/contrib/layout/browser/singlePane/singlePaneNewSessionStrategy.ts |
Treats Changes as a managed draft input. |
src/vs/sessions/contrib/layout/browser/singlePane/singlePaneDockedTabsCoordinator.ts |
Enables and restores Changes for workspace drafts. |
src/vs/sessions/contrib/changes/test/browser/changesViewActions.test.ts |
Tests Changes view availability before creation. |
src/vs/sessions/contrib/changes/browser/changes.contribution.ts |
Removes the created-session visibility gate. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| editors.length !== 1 || | ||
| !(editors[0] instanceof EmptyFileEditorInput) | ||
| ) { | ||
| if (!editors.every(editor => editor instanceof EmptyFileEditorInput || isChangesEditorInput(editor, this._sessionChangesService))) { |
Sandeep Somavarapu (sandy081)
enabled auto-merge (squash)
August 24, 2026 17:31
Sandeep Somavarapu (sandy081)
approved these changes
Aug 24, 2026
Ladislau Szomoru (lszomoru)
approved these changes
Aug 24, 2026
Sandeep Somavarapu (sandy081)
merged commit Aug 24, 2026
6e3879c
into
release/1.135
28 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #332365 from
main.Summary
Validation
npm run compilenpm run precommit./scripts/test.sh --run src/vs/sessions/contrib/changes/test/browser/changesViewActions.test.ts --run src/vs/sessions/contrib/layout/test/browser/desktopSessionLayoutController.test.ts(150 passing)