Skip to content

Add RAII for PIDL types (BSTR-style) and FreeWith(CoTaskMemFree) for CoTaskMem string out-params #2276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
antmor wants to merge 3 commits into
base: main
Choose a base branch
from
+31 −0
Draft

Add RAII for PIDL types (BSTR-style) and FreeWith(CoTaskMemFree) for CoTaskMem string out-params #2276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95f4a29
Add RAII (ILFree) annotation for PIDL types so CsWin32 generates a Sa…
antmor Jul 11, 2026
5f6d49e
Rework PIDL RAII to BSTR-style typedef; add FreeWith(CoTaskMemFree) f…
antmor Jul 11, 2026
dcdb80b
Fix namespace cycle: co-locate PIDL typedefs and ILFree in Shell.Common
antmor Jul 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions generation/WinSDK/autoTypes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,6 +446,32 @@
"InvalidHandleValues": [ -1, 0 ],
"NativeTypedef": true
},
{
"Namespace": "Windows.Win32.UI.Shell.Common",
"Name": "PIDLIST_RELATIVE",
"ValueType": "ITEMIDLIST*",
"CloseApi": "ILFree",
"InvalidHandleValues": [ 0 ],
"NativeTypedef": true
},
{
"Namespace": "Windows.Win32.UI.Shell.Common",
"Name": "PIDLIST_ABSOLUTE",
"ValueType": "ITEMIDLIST*",
"CloseApi": "ILFree",
"AlsoUsableFor": "PIDLIST_RELATIVE",
"InvalidHandleValues": [ 0 ],
"NativeTypedef": true
},
{
"Namespace": "Windows.Win32.UI.Shell.Common",
"Name": "PITEMID_CHILD",
"ValueType": "ITEMIDLIST*",
"CloseApi": "ILFree",
"AlsoUsableFor": "PIDLIST_RELATIVE",
"InvalidHandleValues": [ 0 ],
"NativeTypedef": true
},
{
"Name": "HCOLORSPACE",
"ValueType": "DECLARE_HANDLE",
Expand Down
4 changes: 4 additions & 0 deletions generation/WinSDK/emitter.settings.rsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,10 @@ SHFormatDrive::fmtID=SHFMT_ID
SHGetSetSettings::dwMask=SSF_MASK
IStream::Seek::dwOrigin=STREAM_SEEK
SHGetKnownFolderPath::ppszPath=[FreeWith("CoTaskMemFree")]
SHGetNameFromIDList::ppszName=[FreeWith("CoTaskMemFree")]
StringFromCLSID::lplpsz=[FreeWith("CoTaskMemFree")]
StringFromIID::lplpsz=[FreeWith("CoTaskMemFree")]
IShellItem::GetDisplayName::ppszName=[FreeWith("CoTaskMemFree")]
PSINJECTDATA::InjectionPoint=PSINJECT_POINT
EnumObjects::nType=OBJ_TYPE
EnumSystemFirmwareTables::pFirmwareTableEnumBuffer=byte*
Expand Down
1 change: 1 addition & 0 deletions generation/WinSDK/requiredNamespacesForNames.rsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,6 +669,7 @@ IADesktopP2=Windows.Win32.UI.LegacyWindowsEnvironmentFeatures
DoPrivacyDlg=Windows.Win32.Web.MsHtml
# endregion shlobj.h
# region shlobj_core.h
ILFree=Windows.Win32.UI.Shell.Common
PROPERTYUI_FLAGS=Windows.Win32.UI.Shell.PropertiesSystem
PROPERTYUI_NAME_FLAGS=Windows.Win32.UI.Shell.PropertiesSystem
PROPERTYUI_FORMAT_FLAGS=Windows.Win32.UI.Shell.PropertiesSystem
Expand Down
Loading