metadata: Add audiopolicy.h#4702
Open
riverar wants to merge 3 commits into
Open
Conversation
kennykerr
approved these changes
Jul 16, 2026
kennykerr
reviewed
Jul 16, 2026
| "audioclientactivationparams.h", | ||
| "spatialaudiometadata.h", | ||
| "spatialaudioclient.h", | ||
| "audiopolicy.h", |
Collaborator
There was a problem hiding this comment.
Prefer appending headers to the end of the list unless there is a good reason to add it in some specific order.
Collaborator
Author
There was a problem hiding this comment.
Fair, though note there's these comment blocks at the end of the array which suggests they should be last. (I'm guessing I can ignore that.)
...
// Apiset umbrella fallback (appended last). Modern APIs that no per-DLL host library
// claims — `CreateFileMapping2`, the `*FromApp` file APIs, the package-dependency APIs,
// … — are exported only through an `api-ms-win-*` apiset contract (or a host DLL the
// umbrella records). Because resolution is first-wins and these come last, every
// classic host-DLL mapping above is untouched; only the previously-empty residue is
// stamped with the faithful DLL the umbrella records, matching the reference metadata,
// which likewise leaves no function with an empty library.
"onecore.lib",
"onecoreuap.lib",
// Enclave runtime, resolved dead last. `vertdll.dll` is the VBS-enclave runtime and
// also exports host-side synchronization/enclave functions (`WaitOnAddress`,
// `WakeByAddress*`, `CallEnclave`, `TerminateEnclave`); importing those from
// `vertdll.dll` faults a normal process at load. Placing it after the apiset umbrella
// lets those functions resolve to their loadable `api-ms-win-*` contract first, leaving
// `vertdll.lib` to stamp only genuinely enclave-only residue (`EnclaveSealData`, …).
"vertdll.lib",
];
Collaborator
There was a problem hiding this comment.
I meant the end of the header list not the lib list. Yes, I'd stick any specific lib at the end but before the umbrella libs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds audiopolicy interfaces and types. Is compatible with #4700.