Skip to content

metadata: Add audiopolicy.h#4702

Open
riverar wants to merge 3 commits into
masterfrom
rafael/metadata-audiopolicy
Open

metadata: Add audiopolicy.h#4702
riverar wants to merge 3 commits into
masterfrom
rafael/metadata-audiopolicy

Conversation

@riverar

@riverar riverar commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Adds audiopolicy interfaces and types. Is compatible with #4700.

"audioclientactivationparams.h",
"spatialaudiometadata.h",
"spatialaudioclient.h",
"audiopolicy.h",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer appending headers to the end of the list unless there is a good reason to add it in some specific order.

@riverar riverar Jul 16, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair, though note there's these comment blocks at the end of the array which suggests they should be last. (I'm guessing I can ignore that.)

...
    // Apiset umbrella fallback (appended last). Modern APIs that no per-DLL host library
    // claims — `CreateFileMapping2`, the `*FromApp` file APIs, the package-dependency APIs,
    // … — are exported only through an `api-ms-win-*` apiset contract (or a host DLL the
    // umbrella records). Because resolution is first-wins and these come last, every
    // classic host-DLL mapping above is untouched; only the previously-empty residue is
    // stamped with the faithful DLL the umbrella records, matching the reference metadata,
    // which likewise leaves no function with an empty library.
    "onecore.lib",
    "onecoreuap.lib",
    // Enclave runtime, resolved dead last. `vertdll.dll` is the VBS-enclave runtime and
    // also exports host-side synchronization/enclave functions (`WaitOnAddress`,
    // `WakeByAddress*`, `CallEnclave`, `TerminateEnclave`); importing those from
    // `vertdll.dll` faults a normal process at load. Placing it after the apiset umbrella
    // lets those functions resolve to their loadable `api-ms-win-*` contract first, leaving
    // `vertdll.lib` to stamp only genuinely enclave-only residue (`EnclaveSealData`, …).
    "vertdll.lib",
];

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant the end of the header list not the lib list. Yes, I'd stick any specific lib at the end but before the umbrella libs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants