Skip to content

Only "proper" chord types in mir_eval.chord.QUALITIES #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmcfee merged 8 commits into from
Jan 23, 2025
Merged

Only "proper" chord types in mir_eval.chord.QUALITIES #397

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4d92512
added some chord types in the chord.py regex
maximoskp Nov 26, 2024
cbd5caf
moved chords test
maximoskp Nov 26, 2024
e4656a8
all chord types are understood
maximoskp Nov 29, 2024
21869f9
removed ureachable types
maximoskp Dec 7, 2024
cc0bdcb
added test and removed notebook
maximoskp Jan 23, 2025
8e46c16
correcting test
maximoskp Jan 23, 2025
aeb4ab8
Update tests/test_chord.py
bmcfee Jan 23, 2025
646dc41
Update tests/test_chord.py
bmcfee Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions mir_eval/chord.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,15 +261,11 @@ def scale_degree_to_bitmap(scale_degree, modulo=False, length=BITMAP_LENGTH):
"maj9": [1, 0, 0, 0, 1, 0, 0, 1, 0, 0, 0, 1],
"min9": [1, 0, 0, 1, 0, 0, 0, 1, 0, 0, 1, 0],
"9": [1, 0, 0, 0, 1, 0, 0, 1, 0, 0, 1, 0],
"b9": [1, 0, 0, 0, 1, 0, 0, 1, 0, 0, 1, 0],
"#9": [1, 0, 0, 0, 1, 0, 0, 1, 0, 0, 1, 0],
"min11": [1, 0, 0, 1, 0, 0, 0, 1, 0, 0, 1, 0],
"11": [1, 0, 0, 0, 1, 0, 0, 1, 0, 0, 1, 0],
"#11": [1, 0, 0, 0, 1, 0, 0, 1, 0, 0, 1, 0],
"maj13": [1, 0, 0, 0, 1, 0, 0, 1, 0, 0, 0, 1],
"min13": [1, 0, 0, 1, 0, 0, 0, 1, 0, 0, 1, 0],
"13": [1, 0, 0, 0, 1, 0, 0, 1, 0, 0, 1, 0],
"b13": [1, 0, 0, 0, 1, 0, 0, 1, 0, 0, 1, 0],
"1": [1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0],
"5": [1, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0],
"": [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0],
Expand Down
8 changes: 8 additions & 0 deletions tests/test_chord.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,3 +638,11 @@ def test_validate():
# Test that error is thrown on different-length labels
with pytest.raises(ValueError):
mir_eval.chord.validate([], ["C"])

def test_chord_qualities():
quals = mir_eval.chord.QUALITIES
for q in quals.keys():
try:
c = mir_eval.chord.encode('C' + (len(q) > 0)*':' + q, reduce_extended_chords=True)
except:
Comment thread
bmcfee marked this conversation as resolved.
Outdated
print('problem with quality: ', q)