Skip to content

Refactor/input helper improvements - #128

Open
0xar-ds wants to merge 26 commits into
v1.0.0from
refactor/input-helper-improvements
Open

Refactor/input helper improvements#128
0xar-ds wants to merge 26 commits into
v1.0.0from
refactor/input-helper-improvements

Conversation

@0xar-ds

@0xar-ds 0xar-ds commented Sep 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

after feat/+1.21.11 (i will rebase it so it becomes 26.2, 26.3 once consumed dependencies have vers for 26.3)

  • Get the players' purse from SkyblockAPI's CurrencyAPI 90d2ded
  • Decouple the base *InputHelper from the concrete strategies (AmountStrategy, this time) b17bf74
  • Extend the logic of InstantBuyAmountHelper so it properly counts the fillable player inventory space 19f8808
  • Fix copy pasted InstantBuyAmountHelper#getButtonItemText b15f139
  • Memoize SignInputHelpers' resolved input 48ca013
    • Mostly to dedupe computation on render calls, but will also allow us to introduce a AdjustableWorkingValue such that we could plumb Mouse Scroll events to have the user feature of "adjusting a resolved input" when hovering over a input helper
      • Not including this so we have features to release post 1.0.0, same reason for which I'd argue [v1.0.0] [Feature] Orders overlay #123 should be post v1.0.0 and we should keep v1.0.0 as of a major refactor/reiteration of the codebase and its features, not an addition of new ones
  • Reset State upon sign handled 5bb8a8a
  • Standard event subscription for SignManager::SignQueueDispatcher a1aba4a

0xar-ds added 21 commits August 22, 2026 14:57
@0xar-ds
Drop 1.21.11 & add 26.1.2
68c3206 
Signed-off-by: 0xar-ds <sadden-rope-sleek@duck.com>
@0xar-ds
Bump gradle ver
dcc13c7 
Signed-off-by: 0xar-ds <sadden-rope-sleek@duck.com>
@0xar-ds
Bump kotlin ver
0b45a08 
Signed-off-by: 0xar-ds <sadden-rope-sleek@duck.com>
@0xar-ds
Add 26.1.2 vers
17200b3 
Signed-off-by: 0xar-ds <sadden-rope-sleek@duck.com>
@0xar-ds
Bump loom & update build fn calls per the new api
2423820 
Signed-off-by: 0xar-ds <sadden-rope-sleek@duck.com>
@0xar-ds
Bump fabric loader ver
88f9916 
Signed-off-by: 0xar-ds <sadden-rope-sleek@duck.com>
@0xar-ds
Specify target jvm/runtimes & reorder tasks declarations
3c07e03 
shadowJar was deprecated

Signed-off-by: 0xar-ds <sadden-rope-sleek@duck.com>
@0xar-ds
Bump mod publish plugin
fce0391 
Signed-off-by: 0xar-ds <sadden-rope-sleek@duck.com>
@0xar-ds
Bump stonecutter
06c641f 
Signed-off-by: 0xar-ds <sadden-rope-sleek@duck.com>
@0xar-ds
Bump loombok
23e2824 
Signed-off-by: 0xar-ds <sadden-rope-sleek@duck.com>
@0xar-ds
Bump apache vers
a796695 
Signed-off-by: 0xar-ds <sadden-rope-sleek@duck.com>
@0xar-ds
Bump asm vers for java 25
60f5808 
Signed-off-by: 0xar-ds <sadden-rope-sleek@duck.com>
@0xar-ds
Handle migrations
f11aff7 
Signed-off-by: 0xar-ds <sadden-rope-sleek@duck.com>
@0xar-ds
Yield onto ItemStackTemplates
33d9caf 
Signed-off-by: 0xar-ds <sadden-rope-sleek@duck.com>
@0xar-ds
Move renderer registry' to module system
114c05a 
otherwise we have issues with holders initialization

Signed-off-by: 0xar-ds <sadden-rope-sleek@duck.com>
@0xar-ds
Use SkyblockAPI's CurrencyAPI for purse retrieving
90d2ded 
Signed-off-by: 0xar-ds <sadden-rope-sleek@duck.com>
@0xar-ds
Have each concrete SignInputHelper implement their AmountStrategy::Ma…
b17bf74 
…x computational logic

Signed-off-by: 0xar-ds <sadden-rope-sleek@duck.com>
@0xar-ds
Properly count amount of items fillable to the players inventory per …
19f8808 
…context

Signed-off-by: 0xar-ds <sadden-rope-sleek@duck.com>
@0xar-ds
Fix copy pasted #getButtonItemText
b15f139 
Signed-off-by: 0xar-ds <sadden-rope-sleek@duck.com>
@0xar-ds
Memoize input resolution rather than to compute it for every consumin…
48ca013 
…g path

Signed-off-by: 0xar-ds <sadden-rope-sleek@duck.com>
@0xar-ds
Reset state upon sign handled
5bb8a8a 
Signed-off-by: 0xar-ds <sadden-rope-sleek@duck.com>
@0xar-ds 0xar-ds mentioned this pull request Sep 5, 2026
Open
@0xar-ds
Standard event subscription for SignManagers' Queue Dispatcher
a1aba4a 
Signed-off-by: 0xar-ds <sadden-rope-sleek@duck.com>
@0xar-ds
0xar-ds force-pushed the refactor/input-helper-improvements branch from 8779aba to a1aba4a Compare September 6, 2026 01:52
@mkram17

mkram17 commented Sep 6, 2026

Copy link
Copy Markdown
Owner

Not including this so we have features to release post 1.0.0, same reason for which I'd argue #123 should be post v1.0.0 and we should keep v1.0.0 as of a major refactor/reiteration of the codebase and its features, not an addition of new ones

Good plan.

mkram17 and others added 3 commits September 6, 2026 18:16
@mkram17
Drop imports left unused by the helper refactor
d53f804
@mkram17 @claude
Expire queued sign handlers instead of clearing them on container close
fcb27c1 
The chest closing is the same server-side transition that opens the sign, so
clearing the queue on ContainerCloseEvent races the very sign open it exists to
serve. It usually loses that race harmlessly — SkyblockAPI posts the event a
tick behind the clientbound close packet, which lands it after the open-sign
packet handler in the same task drain — but nothing guarantees the two packets
arrive in one drain, and when they don't the sign silently goes unfilled.

Each handler now carries a deadline and is skipped once past it, which bounds a
handler waiting on a sign that never opens without depending on packet ordering.
Claiming the sign with CONSUMED now also discards the rest of the queue, which
is what runOnNextSignOpen already documented and what the close-clear had been
doing incidentally.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014iXqZFi27zfBERVHkLAjuj
@mkram17 @claude
Do not memoize an input resolution that failed
7451946 
WorkingValue cached whatever resolveInput returned, including the -1 that
getPriceForPosition yields when the bazaar reply has not landed yet. That froze
the button on -1 for the rest of the container load and typed it into the sign;
before memoization every render recomputed, so a transient miss healed itself.

resolveInput now reports failure as an empty Optional and WorkingValue caches
only a value that resolved, so a later render retries. A helper with no market
data renders a blank stack size rather than -1, and clicking it no longer opens
a sign it cannot fill. computeMaxValue returns OptionalInt for the same reason:
BuyOrderAmountHelper divided the purse by that -1, and by a price of 0 it would
have typed Integer.MAX_VALUE.

getPriceForPositionOptional carries the distinction; getPriceForPosition keeps
its -1 sentinel for the callers that only display a price.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014iXqZFi27zfBERVHkLAjuj
@mkram17
Merge remote-tracking branch 'origin/v1.0.0' into refactor/input-help…
0f92d54 
…er-improvements

# Conflicts:
#	build.gradle.kts
#	gradle.properties
#	settings.gradle.kts
#	src/main/java/com/github/mkram17/bazaarutils/features/gui/buttons/CancelOrderAndSearch.java
#	src/main/java/com/github/mkram17/bazaarutils/utils/minecraft/gui/widgets/TextDisplayWidget.java
#	src/main/java/com/github/mkram17/bazaarutils/utils/minecraft/item/groups/ItemGroups.java
#	stonecutter.gradle.kts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkram17 mkram17 mkram17 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@0xar-ds @mkram17