test(orchestra): pin how the parser reports commands it cannot use - #3562
Draft
amanjeetsingh150 wants to merge 1 commit into
Draft
test(orchestra): pin how the parser reports commands it cannot use#3562amanjeetsingh150 wants to merge 1 commit into
amanjeetsingh150 wants to merge 1 commit into
Conversation
The parser consults its own list of commands in two places -- the "Missing Command Options" error for a command written bare that needs a value, and the "Did you mean" suggestion for one it does not recognise. Between them they had a single whole-workspace snapshot, `e020`, for `tapOn`; and the snapshot covering the suggestion path uses `invalidCommand`, which resembles nothing, so the prefix, substring and edit-distance matching was never exercised at all. These describe what the parser does today. No production code changes. The one worth reading is `no declared command is ever reported as invalid`: a command falling out of the parser's list makes it blame the user for a command Maestro does have, which is the worst error it can give. Removing `tapOn` from `objectCommands` fails it. Verify: - ./gradlew :maestro-orchestra:test - 440 tests, 0 failures (6 new, all passing against unmodified production code) Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015vHfmsiT7skZdV13zcbeof
amanjeetsingh150
force-pushed
the
feat/parser-errors-from-schema
branch
from
September 4, 2026 08:48
c9b9ffa to
1939789
Compare
amanjeetsingh150
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #3560. Tests only — no production code changes.
The parser consults its own list of commands in two places: the "Missing Command Options" error for a command written bare that needs a value, and the "Did you mean" suggestion for one it does not recognise. Between them they had a single whole-workspace snapshot (
e020, fortapOn), and the snapshot covering the suggestion path usesinvalidCommand— which resembles nothing, so the prefix, substring and edit-distance matching was never exercised at all.These six tests describe what the parser does today, so there is something to hold it still before anything moves.
The one worth reading is
no declared command is ever reported as invalid: a command falling out of the parser's list makes it blame the user for a command Maestro does have, which is the worst error it can give. RemovingtapOnfromobjectCommandsfails it.Verify:
./gradlew :maestro-orchestra:test— 440 tests, 0 failures (6 new, all passing against unmodified production code)🤖 Generated with Claude Code
https://claude.ai/code/session_015vHfmsiT7skZdV13zcbeof