Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ All notable user-visible changes to Hunk are documented in this file.

### Added

- Added a `--transparent-background` flag and `transparent_background` config option for translucent terminal setups.

### Changed

### Fixed
Expand Down
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -127,9 +127,11 @@ exclude_untracked = false
line_numbers = true
wrap_lines = false
agent_notes = false
transparent_background = false
```

`exclude_untracked` affects Git working-tree `hunk diff` sessions only.
`transparent_background` can also be written as `transparentBackground`.

Custom themes can inherit from any built-in base theme and override only the colors you care about:

Expand Down
20 changes: 20 additions & 0 deletions src/core/cli.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ describe("parseCli", () => {
"--wrap",
"--no-hunk-headers",
"--agent-notes",
"--transparent-background",
"--watch",
]);

Expand All @@ -99,6 +100,25 @@ describe("parseCli", () => {
wrapLines: true,
hunkHeaders: false,
agentNotes: true,
transparentBackground: true,
},
});
});

test("parses transparent background toggles", async () => {
const transparent = await parseCli(["bun", "hunk", "diff", "--transparent-background"]);
const opaque = await parseCli(["bun", "hunk", "diff", "--no-transparent-background"]);

expect(transparent).toMatchObject({
kind: "vcs",
options: {
transparentBackground: true,
},
});
expect(opaque).toMatchObject({
kind: "vcs",
options: {
transparentBackground: false,
},
});
});
Expand Down
12 changes: 11 additions & 1 deletion src/core/cli.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ function buildCommonOptions(
agentContext?: string;
pager?: boolean;
watch?: boolean;
transparentBackground?: boolean;
},
argv: string[],
): CommonOptions {
Expand All @@ -73,6 +74,11 @@ function buildCommonOptions(
wrapLines: resolveBooleanFlag(argv, "--wrap", "--no-wrap"),
hunkHeaders: resolveBooleanFlag(argv, "--hunk-headers", "--no-hunk-headers"),
agentNotes: resolveBooleanFlag(argv, "--agent-notes", "--no-agent-notes"),
transparentBackground: resolveBooleanFlag(
argv,
"--transparent-background",
"--no-transparent-background",
),
};
}

Expand All @@ -90,7 +96,9 @@ function applyCommonOptions(command: Command) {
.option("--hunk-headers", "show hunk metadata rows")
.option("--no-hunk-headers", "hide hunk metadata rows")
.option("--agent-notes", "show agent notes by default")
.option("--no-agent-notes", "hide agent notes by default");
.option("--no-agent-notes", "hide agent notes by default")
.option("--transparent-background", "let terminal background show through Hunk surfaces")
.option("--no-transparent-background", "paint Hunk surfaces with the active theme");
}

/** Attach auto-refresh support to review commands that can reopen their source input. */
Expand Down Expand Up @@ -152,6 +160,8 @@ function renderCliHelp() {
" --wrap / --no-wrap wrap or truncate long diff lines",
" --hunk-headers / --no-hunk-headers show or hide hunk metadata rows",
" --agent-notes / --no-agent-notes show or hide agent notes by default",
" --transparent-background / --no-transparent-background",
" let terminal background show through Hunk surfaces",
" --theme <theme> named theme override",
"",
"Git diff options:",
Expand Down
29 changes: 29 additions & 0 deletions src/core/config.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ describe("config resolution", () => {
[
'theme = "graphite"',
"line_numbers = false",
"transparentBackground = true",
"",
"[patch]",
'mode = "split"',
Expand Down Expand Up @@ -87,6 +88,7 @@ describe("config resolution", () => {
wrapLines: true,
hunkHeaders: false,
agentNotes: true,
transparentBackground: true,
});
});

Expand Down Expand Up @@ -210,6 +212,33 @@ describe("config resolution", () => {
).toThrow('Expected a [custom_theme] table when config selects theme = "custom".');
});

test("accepts transparent background config and CLI overrides", () => {
const home = createTempDir("hunk-config-home-");
mkdirSync(join(home, ".config", "hunk"), { recursive: true });
writeFileSync(join(home, ".config", "hunk", "config.toml"), "transparent_background = true\n");

const cwd = createTempDir("hunk-config-cwd-");
const configured = resolveConfiguredCliInput(
{
kind: "vcs",
staged: false,
options: {},
},
{ cwd, env: { HOME: home } },
);
const overridden = resolveConfiguredCliInput(
{
kind: "vcs",
staged: false,
options: { transparentBackground: false },
},
{ cwd, env: { HOME: home } },
);

expect(configured.input.options.transparentBackground).toBe(true);
expect(overridden.input.options.transparentBackground).toBe(false);
});

test("defaults unspecified themes to graphite, including piped pager-style patch input", () => {
const home = createTempDir("hunk-config-home-");
const cwd = createTempDir("hunk-config-cwd-");
Expand Down
6 changes: 6 additions & 0 deletions src/core/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,9 @@ function readConfigPreferences(source: Record<string, unknown>): CommonOptions {
hunkHeaders: normalizeBoolean(source.hunk_headers),
agentNotes: normalizeBoolean(source.agent_notes),
copyDecorations: normalizeBoolean(source.copy_decorations),
transparentBackground:
normalizeBoolean(source.transparentBackground) ??
normalizeBoolean(source.transparent_background),
};
}

Expand All @@ -252,6 +255,7 @@ function mergeOptions(base: CommonOptions, overrides: CommonOptions): CommonOpti
hunkHeaders: overrides.hunkHeaders ?? base.hunkHeaders,
agentNotes: overrides.agentNotes ?? base.agentNotes,
copyDecorations: overrides.copyDecorations ?? base.copyDecorations,
transparentBackground: overrides.transparentBackground ?? base.transparentBackground,
};
}

Expand Down Expand Up @@ -316,6 +320,7 @@ export function resolveConfiguredCliInput(
hunkHeaders: DEFAULT_VIEW_PREFERENCES.showHunkHeaders,
agentNotes: DEFAULT_VIEW_PREFERENCES.showAgentNotes,
copyDecorations: DEFAULT_VIEW_PREFERENCES.copyDecorations,
transparentBackground: false,
};

if (userConfigPath) {
Expand Down Expand Up @@ -344,6 +349,7 @@ export function resolveConfiguredCliInput(
hunkHeaders: resolvedOptions.hunkHeaders ?? DEFAULT_VIEW_PREFERENCES.showHunkHeaders,
agentNotes: resolvedOptions.agentNotes ?? DEFAULT_VIEW_PREFERENCES.showAgentNotes,
copyDecorations: resolvedOptions.copyDecorations ?? DEFAULT_VIEW_PREFERENCES.copyDecorations,
transparentBackground: resolvedOptions.transparentBackground ?? false,
};

if (resolvedOptions.theme === "custom" && !resolvedCustomTheme) {
Expand Down
1 change: 1 addition & 0 deletions src/core/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ export interface CommonOptions {
hunkHeaders?: boolean;
agentNotes?: boolean;
copyDecorations?: boolean;
transparentBackground?: boolean;
}

export interface CustomSyntaxColorsConfig {
Expand Down
11 changes: 9 additions & 2 deletions src/ui/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import { fileRowId } from "./lib/ids";
import { openSelectedFileInEditor } from "./lib/openInEditor";
import { resolveResponsiveLayout } from "./lib/responsive";
import { resizeSidebarWidth } from "./lib/sidebar";
import { availableThemes, resolveTheme } from "./themes";
import { availableThemes, resolveTheme, withTransparentBackground } from "./themes";

type FocusArea = "files" | "filter" | "note";
type ActiveAddNoteTarget = ActiveAddNoteAffordance & { fileId: string };
Expand Down Expand Up @@ -138,7 +138,14 @@ export function App({
() => availableThemes(bootstrap.customTheme),
[bootstrap.customTheme],
);
const activeTheme = resolveTheme(themeId, detectedThemeMode ?? null, bootstrap.customTheme);
const baseTheme = resolveTheme(themeId, detectedThemeMode ?? null, bootstrap.customTheme);
const activeTheme = useMemo(
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 baseTheme is recomputed on every render because resolveTheme is called without useMemo. For built-in themes resolveTheme returns a stable reference from the THEMES array, so the current activeTheme memo happens to be stable in the common case — but for users with a custom theme buildCustomTheme constructs a fresh object every render, defeating the memo and invoking withTransparentBackground unnecessarily on every render cycle.

Suggested change
const baseTheme = resolveTheme(themeId, detectedThemeMode ?? null, bootstrap.customTheme);
const activeTheme = useMemo(
const baseTheme = useMemo(
() => resolveTheme(themeId, detectedThemeMode ?? null, bootstrap.customTheme),
[themeId, detectedThemeMode, bootstrap.customTheme],
);
const activeTheme = useMemo(
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/ui/App.tsx
Line: 141-142

Comment:
`baseTheme` is recomputed on every render because `resolveTheme` is called without `useMemo`. For built-in themes `resolveTheme` returns a stable reference from the `THEMES` array, so the current `activeTheme` memo happens to be stable in the common case — but for users with a custom theme `buildCustomTheme` constructs a fresh object every render, defeating the memo and invoking `withTransparentBackground` unnecessarily on every render cycle.

```suggestion
  const baseTheme = useMemo(
    () => resolveTheme(themeId, detectedThemeMode ?? null, bootstrap.customTheme),
    [themeId, detectedThemeMode, bootstrap.customTheme],
  );
  const activeTheme = useMemo(
```

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied the suggested memoization so custom themes are not rebuilt on every render before transparent-background wrapping.

This comment was generated by Pi using GPT-5.1 Codex

() =>
bootstrap.input.options.transparentBackground
? withTransparentBackground(baseTheme)
: baseTheme,
[baseTheme, bootstrap.input.options.transparentBackground],
);
const review = useReviewController({ files: bootstrap.changeset.files });
const filteredFiles = review.visibleFiles;
const selectedFile = review.selectedFile;
Expand Down
13 changes: 11 additions & 2 deletions src/ui/diff/pierre.ts
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,16 @@ function strengthenWordDiffBg(lineBg: string, signColor: string) {

/** Resolve the inline word-diff background, strengthening theme colors that are too subtle to see. */
function wordDiffHighlightBg(kind: SplitLineCell["kind"], theme: AppTheme) {
let cached = wordDiffBackgroundCache.get(theme.id);
const cacheKey = [
theme.id,
theme.addedBg,
theme.addedContentBg,
theme.removedBg,
theme.removedContentBg,
theme.contextContentBg,
theme.panelAlt,
].join(":");
let cached = wordDiffBackgroundCache.get(cacheKey);
if (!cached) {
const addition =
hexColorDistance(theme.addedContentBg, theme.addedBg) >= MIN_WORD_DIFF_BG_DISTANCE
Expand All @@ -242,7 +251,7 @@ function wordDiffHighlightBg(kind: SplitLineCell["kind"], theme: AppTheme) {
deletion,
empty: theme.panelAlt,
};
wordDiffBackgroundCache.set(theme.id, cached);
wordDiffBackgroundCache.set(cacheKey, cached);
}

return cached[kind];
Expand Down
36 changes: 35 additions & 1 deletion src/ui/themes.test.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
import { describe, expect, test } from "bun:test";
import { blendHex, hexColorDistance } from "./lib/color";
import { CATPPUCCIN_PALETTES, resolveTheme } from "./themes";
import {
CATPPUCCIN_PALETTES,
resolveTheme,
TRANSPARENT_BACKGROUND,
withTransparentBackground,
} from "./themes";

describe("themes", () => {
test("resolves Catppuccin Latte and Mocha by theme id", () => {
Expand Down Expand Up @@ -90,4 +95,33 @@ describe("themes", () => {
punctuation: CATPPUCCIN_PALETTES.mocha.overlay2,
});
});

test("withTransparentBackground only swaps painted background fields", () => {
const theme = resolveTheme("graphite", null);
const transparent = withTransparentBackground(theme);

expect(transparent).toMatchObject({
background: TRANSPARENT_BACKGROUND,
panel: TRANSPARENT_BACKGROUND,
panelAlt: TRANSPARENT_BACKGROUND,
addedBg: TRANSPARENT_BACKGROUND,
removedBg: TRANSPARENT_BACKGROUND,
contextBg: TRANSPARENT_BACKGROUND,
addedContentBg: TRANSPARENT_BACKGROUND,
removedContentBg: TRANSPARENT_BACKGROUND,
contextContentBg: TRANSPARENT_BACKGROUND,
lineNumberBg: TRANSPARENT_BACKGROUND,
selectedHunk: TRANSPARENT_BACKGROUND,
noteBackground: TRANSPARENT_BACKGROUND,
noteTitleBackground: TRANSPARENT_BACKGROUND,
});
expect(transparent.id).toBe(theme.id);
expect(transparent.label).toBe(theme.label);
expect(transparent.text).toBe(theme.text);
expect(transparent.muted).toBe(theme.muted);
expect(transparent.addedSignColor).toBe(theme.addedSignColor);
expect(transparent.removedSignColor).toBe(theme.removedSignColor);
expect(transparent.syntaxColors).toBe(theme.syntaxColors);
expect(theme.background).not.toBe(TRANSPARENT_BACKGROUND);
});
});
22 changes: 22 additions & 0 deletions src/ui/themes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ import type { AppTheme, ThemeBase } from "./themes/types";
export { CATPPUCCIN_PALETTES } from "./themes/catppuccin";
export type { AppTheme, SyntaxColors, ThemeBase } from "./themes/types";

export const TRANSPARENT_BACKGROUND = "transparent";

export const THEMES: AppTheme[] = [
GRAPHITE_THEME,
MIDNIGHT_THEME,
Expand Down Expand Up @@ -110,3 +112,23 @@ export function resolveTheme(

return fallbackTheme();
}

/** Return a copy of a theme whose painted surfaces allow the terminal background through. */
export function withTransparentBackground(theme: AppTheme): AppTheme {
return {
...theme,
background: TRANSPARENT_BACKGROUND,
panel: TRANSPARENT_BACKGROUND,
panelAlt: TRANSPARENT_BACKGROUND,
addedBg: TRANSPARENT_BACKGROUND,
removedBg: TRANSPARENT_BACKGROUND,
contextBg: TRANSPARENT_BACKGROUND,
addedContentBg: TRANSPARENT_BACKGROUND,
removedContentBg: TRANSPARENT_BACKGROUND,
contextContentBg: TRANSPARENT_BACKGROUND,
lineNumberBg: TRANSPARENT_BACKGROUND,
selectedHunk: TRANSPARENT_BACKGROUND,
noteBackground: TRANSPARENT_BACKGROUND,
noteTitleBackground: TRANSPARENT_BACKGROUND,
};
}
Loading