Declare modx property on modPackageBuilder for PHP 8.2 compatibility - #18
Open
Ibochkarev wants to merge 1 commit into
Open
Declare modx property on modPackageBuilder for PHP 8.2 compatibility#18Ibochkarev wants to merge 1 commit into
Ibochkarev wants to merge 1 commit into
Conversation
Prevents "Creation of dynamic property ...::$modx is deprecated" when instantiating the package builder. Matches modTransportManager convention.
Ibochkarev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Что сделано
modPackageBuilderприсваивает$this->modxв конструкторе, но никогда не объявлял свойство. PHP 8.2+ выдаёт:Этот PR добавляет
public $modx = null, как вmodTransportManager.Как проверить
Exit 0 на PHP 8.4 локально.
Чтобы увидеть исходное предупреждение: создайте
modPackageBuilderво время сборки пакета (менеджер или_build). PHP 8.2+ логировал deprecation на строке 70 до этого изменения.Связанные
Найдено в логе ошибок менеджера.
Совместимость
Только PHP 8.2+. Без изменения runtime-поведения.
Совместимость
Без изменения API. Безопасно для patch-релизов.
Оригинал: modxcms#16989