feat(files): add confirmation dialog before moving files/folders via drag-and-drop - #77
Open
Ibochkarev wants to merge 1 commit into
Open
feat(files): add confirmation dialog before moving files/folders via drag-and-drop#77Ibochkarev wants to merge 1 commit into
Ibochkarev wants to merge 1 commit into
Conversation
Ask before Browser/Directory/Sort so accidental drags (e.g. core into manager) can be cancelled. Show the real destination folder for above/below drops and HTML-encode labels (modxcms#16268).
Ibochkarev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Что сделано
Перед drag-and-drop-перемещением в дереве Files, запускающим
Browser/Directory/Sort, менеджер спрашивает подтверждение с именем элемента и папкой назначения. Выбор No обновляет дерево и пропускает запрос.Для drop
above/belowсоседа диалог показывает родительскую папку (реальный destination). Лейблы HTML-экранированы.Зачем нужно
Случайный drag (например
coreвmanager) может сломать сайт без очевидной перезагрузки (modxcms#16268).Как проверить
Связанные
Refs modxcms#16268
Оригинал: modxcms#16849