feat(system): add "Also in" column to system settings grid - #82
Open
Ibochkarev wants to merge 1 commit into
Open
feat(system): add "Also in" column to system settings grid#82Ibochkarev wants to merge 1 commit into
Ibochkarev wants to merge 1 commit into
Conversation
Show an Also in column on System Settings when the same key exists as a context or user setting. Load distinct override keys only for the system settings processor and add regression tests.
Ibochkarev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Что сделано
Добавляет колонку Also in в System → System Settings. Для каждого системного ключа показывает, существует ли тот же ключ также как Context и/или User setting (
Context,Userили оба).Процессор
System/Settings/GetListгрузит distinct matching keys из таблиц context и user setting для текущей страницы результатов (только системные настройки — списки User/Group setting это не запускают). Грид ExtJS показывает колонку, когдаsettingsType === 'system'.Зачем нужно
Системные ключи могут быть заданы per context или per user, и это легко пропустить. modxcms#16472 просил метку в таблице системных настроек, чтобы видеть, где ещё живёт ключ.
Как проверить
site_name).Связанные
Refs modxcms#16472
Оригинал: modxcms#16843