Add sort options and rating column to Installer package browser - #90
Open
Ibochkarev wants to merge 2 commits into
Open
Add sort options and rating column to Installer package browser#90Ibochkarev wants to merge 2 commits into
Ibochkarev wants to merge 2 commits into
Conversation
- Add 'Sort by' label and default sort (downloads) for grid and thumbs view - Add rating column to package grid - Add rating field to modTransportProvider::find() - Add lexicon entries: rating, sort_by - Fix duplicate column IDs (author-col, downloads-col) - Add change handler for sort combobox in thumbs view - Use single change event to prevent double load Co-authored-by: Cursor <cursoragent@cursor.com>
Show rating in thumbs and details, listen only to select for sort, and reuse sort_by_dots instead of a new lexicon key.
Ibochkarev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Что сделано
sort_by_dots; сортировка перезагружается только наselectauthor-col,downloads-col) исправленыЗачем нужно
modxcms#14845 просил видимый контроль сортировки и колонку рейтинга в браузере пакетов Installer.
Как проверить
--Связанные
Refs modxcms#14845
Оригинал: modxcms#16828