Publish exact-head compiled CSS and jsgrps from Compile Assets - #16999
Open
Ibochkarev wants to merge 1 commit into
Open
Publish exact-head compiled CSS and jsgrps from Compile Assets#16999Ibochkarev wants to merge 1 commit into
Ibochkarev wants to merge 1 commit into
Conversation
Upload allowlisted build outputs via actions/upload-artifact and an inline manifest so PR reviewers can download compiled Manager assets without a local Node/Grunt run.
Ibochkarev
force-pushed
the
feat/16998-compile-assets-artifact
branch
from
August 16, 2026 05:49
dde91f0 to
d5720cf
Compare
Mark-H
requested changes
Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
Compile Assets already builds Manager CSS/JS on relevant PRs, but nothing was downloadable afterward. Reviewers had a green check and still needed a local Node/Grunt run to exercise
compress_jsManager mode.The workflow now:
actions/upload-artifact@v4(index/login/installer CSS + min counterparts, plusmanager/assets/modext/modx.jsgrps-min.js);compiled-assets-manifest.jsoninline in the workflow step (schema version, repo, PR number, head/base SHAs, run id/attempt, output sizes/SHA-256, ordered jsgrps input map).Triggers also cover mapped Manager JS under
manager/assets/modext/**andFileAPI.js.permissions: contents: readandpersist-credentials: falsekeep the untrusted build surface smaller.Not a custom maintained tool: there is no
.github/scripts/*helper to own long-term. That is intentional after #16971 (maintainers closed a custom PHPCS wrapper as something the project should not maintain). Here the only non-standard bit is a short inline Python block inside the workflow for the JSON manifest; upload stays on stockactions/upload-artifact@v4with an explicit path list.How to test
_build/templates/**/ mapped modext JS) and wait for Compile Assets.compiled-assets-<head12>.modx.jsgrps-min.js, andcompiled-assets-manifest.json.head_shamatches the PR head andoutputs/jsgrps_inputshashes look sane.Related issue(s)/PR(s)
Resolves #16998.
Addresses the jsgrps ask in #16998 (comment).
Avoids the “custom script to maintain” rejection pattern from #16971 / #16971.
Compatibility notes
CI workflow only. No runtime or platform changes.
Breaking change assessment
No public API or product behavior changes. Safe for a patch release.
Test coverage
No product unit tests. Verification is the workflow run + downloaded artifact contents.
Contributors
Issue #16998; jsgrps follow-up from @opengeek.
AI tool use
AI helped draft the workflow and PR text. Reviewers should treat the workflow YAML as the source of truth.