Repository navigation
fix(data-browser): validate messages arriving in the webview VSCODE-804 - #1366
Merged
Merged
Conversation
alenakhineika
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hardens inbound message handling in the data browser webview:
On the approach: the check originally suggested on the ticket,
event.source !== window.parent, is not viable here. The webview app runs in a sandboxed frame wherewindow.parentis the frame itself, so that comparison discards legitimate messages. This was verified against a running extension host, where the origin comparison holds for everything VS Code delivers.Checklist
Motivation and Context
Open Questions
Dependents
Targets the VSCODE-805 branch, since it builds on that work. Retarget to
mainonce #15 merges.Types of changes