Repository navigation
INTPYTHON-698 Add EmbeddedFieldIndex and EmbeddedFieldUniqueConstraint - #376
Merged
timgraham merged 1 commit intoFeb 1, 2026
Conversation
WaVEV
force-pushed
the
INTPYTHON-698-Define-indexes-on-Embedded-Models-in-Top-Level-Model
branch
from
August 25, 2025 03:05
998a080 to
5dd116b
Compare
timgraham
reviewed
Aug 25, 2025
WaVEV
force-pushed
the
INTPYTHON-698-Define-indexes-on-Embedded-Models-in-Top-Level-Model
branch
from
August 25, 2025 23:16
3e722d1 to
2010776
Compare
timgraham
changed the title
WaVEV
force-pushed
the
INTPYTHON-698-Define-indexes-on-Embedded-Models-in-Top-Level-Model
branch
6 times, most recently
from
September 6, 2025 03:34
86aed5e to
9636c17
Compare
WaVEV
force-pushed
the
INTPYTHON-698-Define-indexes-on-Embedded-Models-in-Top-Level-Model
branch
from
September 6, 2025 19:33
9636c17 to
e1c98f3
Compare
WaVEV
marked this pull request as ready for review
September 6, 2025 19:40
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
WaVEV
force-pushed
the
INTPYTHON-698-Define-indexes-on-Embedded-Models-in-Top-Level-Model
branch
from
October 11, 2025 15:19
e1c98f3 to
eb29e72
Compare
Contributor
|
Concurrent with the release of this, will we stop support unique constraints and indexes declared on embedded models and their fields? Or perhaps we should try to put that through a deprecation process? |
Collaborator
|
Probably should be deprecated in case anyone is using them. |
Contributor
We should put this in a deprecation process. For the first bump where this change occurs, we'll let them know that the deprecation is coming. |
WaVEV
force-pushed
the
INTPYTHON-698-Define-indexes-on-Embedded-Models-in-Top-Level-Model
branch
from
October 30, 2025 00:08
eb29e72 to
c0707cc
Compare
WaVEV
force-pushed
the
INTPYTHON-698-Define-indexes-on-Embedded-Models-in-Top-Level-Model
branch
3 times, most recently
from
November 3, 2025 01:38
d40c24a to
9c56be4
Compare
WaVEV
deleted the
INTPYTHON-698-Define-indexes-on-Embedded-Models-in-Top-Level-Model
branch
November 3, 2025 01:49
WaVEV
restored the
INTPYTHON-698-Define-indexes-on-Embedded-Models-in-Top-Level-Model
branch
November 3, 2025 02:18
WaVEV
force-pushed
the
INTPYTHON-698-Define-indexes-on-Embedded-Models-in-Top-Level-Model
branch
4 times, most recently
from
November 9, 2025 21:04
1c28e45 to
d9c04dc
Compare
timgraham
reviewed
Jan 5, 2026
WaVEV
force-pushed
the
INTPYTHON-698-Define-indexes-on-Embedded-Models-in-Top-Level-Model
branch
from
January 7, 2026 00:33
3e4b51f to
9cfc1dc
Compare
timgraham
reviewed
Jan 11, 2026
WaVEV
force-pushed
the
INTPYTHON-698-Define-indexes-on-Embedded-Models-in-Top-Level-Model
branch
from
January 18, 2026 18:11
5742b99 to
16416bb
Compare
timgraham
reviewed
Jan 20, 2026
timgraham
reviewed
Jan 22, 2026
timgraham
force-pushed
the
INTPYTHON-698-Define-indexes-on-Embedded-Models-in-Top-Level-Model
branch
from
January 24, 2026 01:51
815fa45 to
17cb927
Compare
timgraham
reviewed
Jan 24, 2026
Comment on lines
+67
to
+68
| Indexing ``EmbeddedModelField`` | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |
Contributor
There was a problem hiding this comment.
Need some explanation of if/how this functionality works on the other embedded field variants (array, polymorphic).
Collaborator
Author
There was a problem hiding this comment.
I haven't considered that 😬 , EMAF is an easy win. Shall we also allow to index over non shared fields in polymorphic?
Collaborator
Author
There was a problem hiding this comment.
Maybe we have to open a new ticket for polymorphic. they aren't very complicated but is a bit out of scope.
Collaborator
Author
There was a problem hiding this comment.
Also, do we need mention how it won't work on polymorphics? because, an exception will be raised or a check's error if the user wants to create an index on that kind of field. And in the docs we only present the indexing of EMF and EMAF no more.
timgraham
force-pushed
the
INTPYTHON-698-Define-indexes-on-Embedded-Models-in-Top-Level-Model
branch
from
January 28, 2026 16:25
a3b164b to
bca2685
Compare
timgraham
reviewed
Jan 28, 2026
timgraham
force-pushed
the
INTPYTHON-698-Define-indexes-on-Embedded-Models-in-Top-Level-Model
branch
4 times, most recently
from
January 31, 2026 02:49
c6b2885 to
56175ff
Compare
timgraham
reviewed
Jan 31, 2026
timgraham
changed the title
Co-authored-by: Tim Graham <timograham@gmail.com>
timgraham
force-pushed
the
INTPYTHON-698-Define-indexes-on-Embedded-Models-in-Top-Level-Model
branch
from
January 31, 2026 23:29
1a290e8 to
fefbaa1
Compare
timgraham
approved these changes
Feb 1, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.