GODRIVER-3884 Use gpg verification for libmongocrypt windows build variant#2404
Merged
prestonvasquez merged 5 commits intoJun 2, 2026
Conversation
github-actions
Bot
added
the
review-priority-normal
Contributor
API Change ReportNo changes found! |
Contributor
🧪 Performance ResultsCommit SHA: a8b99bbThe following benchmark tests for version 6a1f05454c0334000798bded had statistically significant changes (i.e., |z-score| > 1.96):
For a comprehensive view of all microbenchmark results for this PR's commit, please check out the Evergreen perf task for this patch. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…ows tarball
- Bump LIBMONGOCRYPT_TAG to 1.18.2
- Add GPG signature verification on the Windows download path
- Keep compile.sh-based install for Linux/macOS (the published Linux/macOS
release variants are nocrypto and the Go driver does not provide crypto hooks)
prestonvasquez
force-pushed
the
ci/godriver-3884-update-libmongocrypt-urls-for-1.18.0+
branch
from
52e0843 to
f00658a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the libmongocrypt installation flow, bumping the pinned libmongocrypt version from 1.15.1 to 1.18.2 and adding PGP signature verification of the prebuilt tarball on the Windows path. The non-Windows path still clones the upstream repo and runs compile.sh. The Taskfile entry for install-libmongocrypt is reformatted to multi-line.
Changes:
- Bump
LIBMONGOCRYPT_TAGto1.18.2. - On Windows, download the prebuilt tarball, fetch the MongoDB public key, and verify the detached
.ascsignature in an isolatedGNUPGHOMEbefore extracting. - Reformat the
install-libmongocrypttask definition inTaskfile.yml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Taskfile.yml | Reformat install-libmongocrypt task command list to multi-line YAML. |
| etc/install-libmongocrypt.sh | Bump libmongocrypt to 1.18.2; add GPG signature verification of the Windows tarball; reindent. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
prestonvasquez
changed the title
prestonvasquez
changed the title
prestonvasquez
deleted the
ci/godriver-3884-update-libmongocrypt-urls-for-1.18.0+
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GODRIVER-3884
Verify signature of downloaded libmongocrypt tarballs