Skip to content

DRIVERS-3377 Update deep_bson.json for compatibility with strong-typed benchmarks#1885

Merged
BorisDog merged 4 commits into
mongodb:masterfrom
BorisDog:benchmarks_data_update
May 29, 2026
Merged

DRIVERS-3377 Update deep_bson.json for compatibility with strong-typed benchmarks#1885
BorisDog merged 4 commits into
mongodb:masterfrom
BorisDog:benchmarks_data_update

Conversation

@BorisDog
Copy link
Copy Markdown
Contributor

This PR updates the leaf nodes structure from

{
    "right": {
        "right": "...",
        "left": "..."
    },
    "left": {
        "right": "...",
        "left": "..."
    }
}

to

{
    "right": {
        "rightValue": "...",
        "leftValue": "..."
    },
    "left": {
        "rightValue": "...",
        "leftValue": "..."
    }
}

In deep_bson.json

Please complete the following before merging:

  • [v] Is the relevant DRIVERS ticket in the PR title?
  • [v] Update changelog.
  • [v] Test changes in at least one language driver.
  • [] Test these changes against all server versions and topologies (including standalone, replica set, and sharded
    clusters). NA

@BorisDog BorisDog requested a review from a team as a code owner January 21, 2026 21:24
@BorisDog BorisDog requested review from dariakp, jyemin and vbabanin and removed request for a team January 21, 2026 21:24
Copy link
Copy Markdown
Member

@vbabanin vbabanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a typed benchmarks POC in the Java driver (PR#1887) to validate the proposed update. It passes.
Evergreen run: link

LGTM!

Copy link
Copy Markdown
Contributor

@qingyang-hu qingyang-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dariakp dariakp requested review from a team and NoahStapp and removed request for a team May 28, 2026 14:25
@BorisDog BorisDog merged commit 8b2a36d into mongodb:master May 29, 2026
6 checks passed
@BorisDog BorisDog deleted the benchmarks_data_update branch May 29, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants