fix(moonrun): clear errno for macOS pid fallback#1911
Merged
peter-jerry-ye merged 1 commit intoJul 17, 2026
Merged
Conversation
Changed Files
|
peter-jerry-ye
marked this pull request as ready for review
July 17, 2026 08:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
moonbitlang/async#505 enabled process tests that exposed a macOS-only failure in the WASM async host. The macOS PID-handle path intentionally returns the invalid-handle sentinel to select the kqueue fallback, but unlike the native C implementation it left a stale errno behind.
Process::from_pidthen interpreted that stale errno as a new failure.What changed
Why this is correct
The change restores parity with the native implementation, which returns the sentinel with errno set to zero. The sentinel still selects the existing kqueue path; only the stale error state is removed.
Scope
The runtime change is limited to the non-Linux Unix PID-handle fallback. Other platforms and process paths are unchanged.