Skip to content

Added media events to "NativeEvents" object#2727

Open
nbish11 wants to merge 1 commit into
mootools:masterfrom
nbish11:add-media-events-feature
Open

Added media events to "NativeEvents" object#2727
nbish11 wants to merge 1 commit into
mootools:masterfrom
nbish11:add-media-events-feature

Conversation

@nbish11

@nbish11 nbish11 commented Jul 9, 2015

Copy link
Copy Markdown
Contributor

No description provided.

@SergioCrisostomo

Copy link
Copy Markdown
Member

Nice!

Related: #2520

@GCheung55

Copy link
Copy Markdown
Contributor

@nbish11 Thank you for the contribution! Could you also add some tests as well? It will help the code base be more reliable with your changes.

Here is an example for writing tests. Please check out the Spec folder as well.

@nbish11

nbish11 commented Aug 13, 2015

Copy link
Copy Markdown
Contributor Author

@GCheung55 I'm not very good at writing tests, but if you can link the original tests for the events already there (or a more specialized example of writing tests for events), I'll be happy to write some.

@SergioCrisostomo

Copy link
Copy Markdown
Member

I would also like to see this being included, but looking deeper into this I suggest delaying this.

The problematic is that old browsers don't support this. So this would have to be included in a future MooTools version that has dropped old Browsers.

The spec could be something like this maybe, using native event dispatcher API, but I think some events like progress might have to be normalized inside MooTools because they work different in different browsers.

@SergioCrisostomo SergioCrisostomo added this to the 1.6.0 milestone Aug 13, 2015
@arian

arian commented Aug 14, 2015

Copy link
Copy Markdown
Member

@SergioCrisostomo you can't even normalize these events, because older browsers don't have video/audio support at all. Besides not all events that are currently in NativeEvents are supported by all browsers (input/paste), but it's still useful that MooTools directly redirects it to the native/browser events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants