fix: don't panic on quoted Reference URIs - #118
Merged
Conversation
Interpolating a Reference URI into an etree path made FindElement panic when the URI contained a quote. Look up referenced elements by attribute value instead, and save the crashing fuzzer input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The scheduled fuzzer crashed in run 31659873348 with:
findReferencedElementinterpolated theReferenceURI into an etree path (.//[@ID='%s']). A quote in the URI madeFindElement/MustCompilePathpanic.Look up referenced elements by walking attribute values instead, and save the crashing input in the fuzz corpus.
Test plan
go test ./...go test -run=FuzzValidator/9f0b5d517ccd5fefgo test -run='TestReferenceURIWithQuoteDoesNotPanic|TestValidatorQuotedReferenceURI'