Add helpers to insert XML or text into a signature template - #124
Open
adamdecaf wants to merge 1 commit into
Open
Add helpers to insert XML or text into a signature template#124adamdecaf wants to merge 1 commit into
adamdecaf wants to merge 1 commit into
Conversation
Adds InsertXMLintoSignatureTemplate, InsertTextIntoSignatureTemplate, and PrepPKCS8PrivateKey for assembling enveloped signatures. Cherry-picked from daugminas/signedxml@4f7152f and @cf137e6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds convenience helpers for assembling enveloped signatures:
InsertXMLintoSignatureTemplate— nest a document under the first<Object>InsertTextIntoSignatureTemplate— set that object's textPrepPKCS8PrivateKey— decode a PEM PKCS Fix golint import path #8 key forSigner.SignSource
Cherry-picked from daugminas:
Comments were translated to English to match the rest of the package.
PrepPKCS8PrivateKeynow errors on invalid PEM instead of panicking.Tests
go test .passes.